CODEWITHSUNDEEP
javascript
Vincent
Vincent

Reputation: 1557

split() is not giving the expected outcome

I'm having problems why my .split() function. somehow when i splay my line the first [0] element in the array can be accessed but the 2nd [1] can't

I have the following string:

 ,{"relationID":"000001","recID":"1d2712eb-4f08-4b4f-b6e9-600c9631b503"

And the code below is how i try to split this (tempArray contains a x number of strings like the above):

var templine = tempArray[i].substr(1, tempArray[i].length);
//alert(templine);
var line = templine.split(',');
var s1 = line[0].split('"')[3];
var s2 = line[1].split('"')[3];

when i use alert(s1) or alert(s2) i do get the value however, the folowing error always occurs on the last line (var s2):

caught TypeError: Cannot read property 'split' of undefined

this causes the rest of my script to crash and it won't finish what it's supposed to, displaying an empty page.

My question, what is going wrong here? why does s1 function properly and s2 which is exactly the same except for the index of the line array crash my script.

I want to emphasise when i use the alert function to check the value of my variable s1 and s2 they do contain the right value.

EDIT: maybe a nice bonus since there might be an easyer way. after I've gotten the values s1 and s2 i want to put them in a map like so:

map[s2] = s1;

as you can probably tell the string i use is the result of splitting 1 humongous string on ('}'). the code displayed here is what i do when looping trough this array.

Upvotes: 0

Views: 118

Answers (1)

Walter Macambira
Walter Macambira

Reputation: 2605

That can only be caused by a attempt to access element on the array that is really undefined. Probably your input is not what you are expecting.

Check if line.length > 1 before you try to read those indexes of the array.

As it seems to be a JSON, may be you should try to parse the JSON, it would make your code more readable and reliable. Check JSON.parse browser compatibility before using it (IE8+).

For example:

var data = JSON.parse('{ "field1": "value1", "field2": "value2" }');

var s1 = data['field1'];
var s2 = data['field2'];

Hope I've helped.

Upvotes: 2

Related Questions