CODEWITHSUNDEEP
javashell
Abhijeet Panwar
Abhijeet Panwar

Reputation: 1857

Can't execute Shellscript successfully using getruntime.exec()

I have written a code to execute a script from java : 

 String wrapper_script=homedir+"/blast_distribute.sh "+" --seqs="+seqs+" --i="+formobj.getUpFile().getFileName()+"  "+formobj.getSelected_program();

 script_exec=Runtime.getRuntime().exec(wrapper_script);

This works perfect for me as command is executed successfully. Now I need to run this command as other user so I need to execute a command in a format like :

su username -c 'command'

SO I have edited above script_exec string as : 

String wrapper_script1="su - "+username+" -c "+"'"+wrapper_script+"'";

I have printed wrapper_script1 which diplays:

su - abhijeet -c '/home/abhijeet//blast_distribute.sh --seqs=1562 --i=mPS_0.contigs.fasta'

If I run same command directly on Linux,It works exactly as I need.But When I am running through :

script_exec=Runtime.getRuntime().exec(wrapper_script1); It does't work properly ,In my error stream I get error as

su: unrecognized option '--seqs=1562' Try `su --help' for more information.

I have tried a lot but could't resolve the issue.What can be the reason for this issue?

Upvotes: 0

Views: 339

Answers (1)

Dmitry Ginzburg
Dmitry Ginzburg

Reputation: 7461

You should use multiple parameters run for this:

Runtime.getRuntime().exec(new String[] {"su", "-", username, "-c",
        homedir + "/blast_distribute.sh " + " --seqs=" + seqs + " --i=" + formobj.getUpFile().getFileName() + "  " + formobj.getSelected_program()
});

You're getting the error, because ' is not treated here as a enclosing characters, but as a parameters for su command.

Let's look into details. When you type into console some command like su - jsmith -c 'aba --cabga', what you're doing is: "run command su with such an arguments: -, jsmith, -c, aba --caba (one argument for multiple words)".

The same thing you should do in your Java code. There's special command in Java API for running the concrete command with concrete arguments instead of parsing line as shell do: Runtime.exec(String[]): the first argument is command, the next are the arguments. That's what we do in this code block.

Upvotes: 2

Related Questions