CODEWITHSUNDEEP
wpfmvvmwpf-controls
csensoft
csensoft

Reputation: 743

Problems writing too much custom controls in WPF

I am working on new WPF/MVVM project, where I see all most all controls are written for different needs, right from textbox to treeview. All are rewritten for simple need, for example, grid,stackpanel control are rewritten to add space between each item and textbox is rewritten to include label for it so that it has both label and text input are on itself.

My question : Is there any serious issue we would encounter because of this customization? Already, I am seeing issues with aligning all controls, will i would see any more issues because of this?.

Upvotes: 0

Views: 92

Answers (1)

Troels Larsen
Troels Larsen

Reputation: 4631

You should never create a custom or user control to add margins, a label to a TextBox, or a new ItemTemplate to a ListBox.

UserControls are for grouping frequently used combinations of controls into one reuseable control. An example may be a custom List-of-Values control that opens a dialog. This would be fine to implement as a UserControl.

Custom controls are good when a native control does not suit your needs. Say that you want to reimplement a DateTimePicker from scratch because the native one doesn't include milliseconds.

There are no serious issues as such, but you may find yourself maintaining all these controls for the next many years without there being a need to do so.

Settings Margins should be done in the View where you are using it, or on a Style in a ResourceDictionary.

This is of course only my opinion (and that of many others, I except), but if you find that the majority of your controls are 'customized' this way, you are doing it wrong.

Style and Templates rather than UserControls and custom controls.

The main issue is that you lose the ability to alter margins only in a single view. If you change your custom controls' inner paddings and margins, you will be changing all the views in your solution. If you use a style, you can always override it by defining a new style in the view, or by setting the property directly.

Upvotes: 1

Related Questions