CODEWITHSUNDEEP
javaunit-testingmockitochainingmethod-chaining
gjain
gjain

Reputation: 4518

Dynamic chaining "thenReturn" in mockito

I have a Tuple mock class, whose getString(0) and getString(1) methods are expected to be called n times. Instead of writing something like, 

when(tuple.getString(0)).thenReturn(logEntries[0]).thenReturn(logEntries[1])...thenReturn(logEntries[n - 1])

manually, I tried the following:

OngoingStubbing stubbingGetStringZero = when(tuple.getString(0)).thenReturn(serviceRequestKey);
OngoingStubbing stubbingGetStringOne = when(tuple.getString(1)).thenReturn(logEntries[0]);
for (int i = 1; i < n; i++) {
    stubbingGetStringZero = stubbingGetStringZero.thenReturn(serviceRequestKey);
    stubbingGetStringOne = stubbingGetStringOne.thenReturn(logEntries[i]);
}

The expected result is that all calls to tuple.getString(0) should return the String serviceRequestKey and each call to tuple.getString(1) should return a different String logEntries[i] ie. ith invocation of tuple.getString(1) returns ith element of logEntries array.

However, due to some odd reason, things are getting mixed up, and second invocation to tuple.getString(1) returns the String serviceRequestKey instead of logEntries[1]. What am I missing here?

Upvotes: 20

Views: 14660

Answers (4)

Michael Hegner
Michael Hegner

Reputation: 5823

I know that post is older, but maybe it helps:

    OngoingStubbing<Boolean> whenCollectionHasNext = when(mockCollectionStream.hasNext());
    for (int i = 0; i < 2; i++) {
        whenCollectionHasNext = whenCollectionHasNext.thenReturn(true);
    }
    whenCollectionHasNext = whenCollectionHasNext.thenReturn(false);

Upvotes: -1

gjain
gjain

Reputation: 4518

Well, the right way to do this would be: 

import org.mockito.AdditionalAnswers;

String[] logEntry = // Some initialization code
List<String> logEntryList = Arrays.asList(logEntry);
when(tuple.getString(1)).thenAnswer(AdditionalAnswers.returnsElementsOf(logEntryList));

On each invocation, successive elements of logEntry array are returned. Thus, ith invocation of tuple.getString(1) returns ith element of logEntry array.

P.S: The example in documentation of returnsElementsOf (as of this writing) is not updated (it still uses ReturnsElementsOf example): http://docs.mockito.googlecode.com/hg/1.9.5/org/mockito/AdditionalAnswers.html#returnsElementsOf(java.util.Collection)it

Upvotes: 24

Nadir
Nadir

Reputation: 1379

If I understood well, you want your mock to return different results depending on the invocation (meaning result1 when invoked for the first time, result2 when invoked for the second time etc)- this can be accomplished with such thing

Mockito.when(tuple.getString(0)).thenReturn(serviceRequestKey,logEntries[0],logEntries[1])

With this you will get serviceRequestKey on first invocation, logEntries[0] on second etc...

If you want something more sophisticated, like change the return depending on the param in the method use thenAnswer() as shown here

Upvotes: 6

The F
The F

Reputation: 42

Not sure I understand Mockito well enough to understand your example, but wouldn't you want something like:

Mockito.when(tuple.getString(0)).thenReturn(serviceRequestKey);
for(int i = 0;i < logEntries.length;i++) {
    Mockito.when(tuple.getString(i+1)).thenReturn(logEntries[i]);
}

Upvotes: -1

Related Questions