CODEWITHSUNDEEP
carrayspointersreplace
chutsu
chutsu

Reputation: 14103

Search string in file (C)

So my code isn't working...

test.c:27: warning: passing argument 1 of ‘search’ from incompatible pointer type

which is the fgets line.

My code opens a file, reads the file line by line, and I'm trying to create a "search" function that will return a value that indicates whether that string is found on that line of the file.

My ultimate goal is to achieve a search and replace program. But one step at a time eh? this is what I have so far:

#include <stdio.h>
#include <string.h>

int search(const char *content[], const char *search_term)
{
    int t;

    for(t=0; content[t]; ++t){
        if(!strcmp(content[t], search_term)){
            return t; // found
        }
    }
    return 0; // not found
}


int main(int argc, char *argv[])
{
    FILE *file;
    char line[BUFSIZ];
    int linenumber=0;
    char term[20] = "hello world";

    file = fopen(argv[1], "r");
    if(file != NULL){
        while(fgets(line, sizeof(line), file)){
            if(search(line, term) != -1){
                printf("Search Term Found!!\n");
            }
            ++linenumber;
        }
    }       
    else{
        perror(argv[1]); 
    }

    fclose(file);
    return 0;
}

Upvotes: 3

Views: 7947

Answers (6)

Phil
Phil

Reputation: 2927

Try this method out instead:

int search(const char *content, const char *search_term)
{
   char *result = strstr(content, search_term);
   if(result == NULL) return 0;
   return (int)(result - content);
}

The difference between result and content is exactly the index at which the result was found. I believe this is what you are looking for?

I think though there is room for improvement. You don't want to return 0 on no match, because that can be confused for a match at the first byte position, which is also 0. Instead, return -1 if you have to return an integer:

if(result == NULL) return -1;

Going further, however, you can see how this method is just a wrapper for functionality you aren't even using later. If all you care about in main is whether the string was found, just remove this function completely and write main like this:

int main(int argc, char *argv[])
{
   FILE *file;
   char line[BUFSIZ];
   int linenumber = 1;
   char term[20] = "hello world";

   file = fopen(argv[1], "r");
   if(file != NULL) {
      while(fgets(line, sizeof(line), file)){
         if(strstr(line, term) != NULL) {
             printf("Search Term Found at line %d!\n", linenumber);
         }
         ++linenumber;
      }
   }
   else {
      perror(argv[1]);
   }

   fclose(file);
   return 0;
}

Upvotes: 0

codaddict
codaddict

Reputation: 455122

Change

int search(const char *content[], const char *search_term)

to

int search(const char content[], const char *search_term)

EDIT:

Also change:

if(!strcmp(content[t], search_term)){

to

if(!strcmp(&content[t], search_term)){

or

if(!strcmp(content + t, search_term)){

Since you are using strcmp to find the match, you'll not be able to find all occurrences of the search string the the file. You'll find only those lines that end in the search_string.

Example: your search string is "hello world" and say the file has 2 lines:

I wrote hello world
hello world is good

In this case your program will be able to find only the 1st occurrence and not the 2nd.

Even for this match to be found there are some more changes needed to your code:

The string read by fgets has a trailing newline, you'll have to get rid of it like:

while(fgets(line, sizeof(line), file)){
  line[strlen(line)-1] = 0;

Also when the search fails you are returning 0, which should be changed to -1.

Upvotes: 3

philcolbourn
philcolbourn

Reputation: 4122

  1. fix the argument to search as others have said.
  2. You need to take the address of content[t] to pass to strcmp. content[t] is a character, not a string.

  3. I think you still have a few other issues as well. return 0; for example - perhaps return -1?

  4. Also... I think you might need to use strncmp to find the term in the line.

eg.

int search(char *content, const char *search_term)
{
    int t;

    for(t=0; content[t]; ++t){
        if(!strncmp(&content[t], search_term, strlen(search_term))){
            return t; // found
        }
    }
    return -1; // not found
}

Upvotes: 1

Aiden Bell
Aiden Bell

Reputation: 28386

The argument type:

const char *content[]

Is incorrect. Use :

const char *content

/

#include <stdio.h>
#include <string.h>

int search(const char *content, const char *search_term)
{
    int t;

    for(t=0; content+t; ++t){
        if(!strcmp(content[t], search_term)){
            return t; // found
        }
    }
    return 0; // not found
}


int main(int argc, char *argv[])
{
    FILE *file;
    char line[BUFSIZ];
    int linenumber=0;
    char term[20] = "hello world";

    file = fopen(argv[1], "r");
    if(file != NULL){
        while(fgets(line, sizeof(line), file)){
            if(search((const char*)line, term) != -1){
                printf("Search Term Found!!\n");
            }
            ++linenumber;
        }
    }       
    else{
        perror(argv[1]); 
    }

    fclose(file);
    return 0;
}

Upvotes: 2

Seb
Seb

Reputation: 2715

try this :

int search(const char *content, const char *search_term)

Upvotes: 1

Thorsten79
Thorsten79

Reputation: 10128

If I understand you correctly you are just re-implementing the strstr() libc function in a very inefficient way.

Upvotes: 2

Related Questions