CODEWITHSUNDEEP
javaandroidlistview
Davlog
Davlog

Reputation: 2248

ArrayAdapter position is wrong

public class SongListAdapter_AddMode extends ArrayAdapter{

Context context;
ArrayList<Song> songs;

public SongListAdapter_AddMode(Context context, ArrayList<Song> songs) {
    super(context, R.layout.list_item1_addmode, songs );
    this.songs = songs;
    this.context = context;
}

@Override
public View getView(int position, View convertView, ViewGroup parent){

    ViewHolder holder;
    final int pos = position;
    Log.d("TAG", "position :" + position);
    Song currentSong = songs.get(position);
    Log.d("TAG", "position : " + position );

    if( convertView == null ){
        holder = new ViewHolder();

        convertView = LayoutInflater.from(context).inflate( R.layout.list_item1_addmode, parent, false );

        holder.titleLabel = (TextView) convertView.findViewById( R.id.topLabel );
        holder.artistLabel = (TextView) convertView.findViewById( R.id.bottomLabel );
        holder.cover = (ImageView) convertView.findViewById( R.id.list_image );
        holder.button = (ImageView) convertView.findViewById(R.id.addButton);
        holder.button.setOnClickListener( new OnClickListener() {

            @Override
            public void onClick(View v) {
                Log.d("TAG", "pos" + pos );
            }
        });
        convertView.setTag(holder);

    }else{
        holder = (ViewHolder) convertView.getTag();
    }

    Uri coverPath = ContentUris.withAppendedId(Uri.parse("content://media/external/audio/albumart"), currentSong.getID() );

    Picasso.with(context).load( coverPath ).error( R.drawable.untitled ).into( holder.cover );
    holder.titleLabel.setText( currentSong.getName() );
    holder.artistLabel.setText( currentSong.getArtistName() );

    return convertView;
}

private class ViewHolder {
    TextView titleLabel;
    TextView artistLabel;
    ImageView cover;
    ImageView button;
}

}

Well this is a small example of what an ArrayAdapter might look like. As you can see in the getView() method, I get the currentSong from a list which is actually very huge. It contains 1600~ Songs. When I print the position to the LogCat, it says 0 up to 7. How am I getting the correct position in the song list but when I print it, it is totally different?

I ALWAYS get the correct song. Even in the 900~ and above. But the position(LogCat) is always from 0 up to 7...

I need to get the current row. I want to add an onClickListener() to a button from the current View in this method and when I click it, I want to do something which I cannot do with an onItemClickListener() on the ListView.

Upvotes: 2

Views: 789

Answers (4)

Erkan
Erkan

Reputation: 165

When your view has wrong position ids or displays wrong items in your autocomplete dropdown view, then instantiate your view like this (Kotlin):

val view: View = convertView ?: LayoutInflater.from(context).inflate(resourceId, parent, false)

Upvotes: 0

Simas
Simas

Reputation: 44188

It seems that you set the button click listener to print the position of the recyclable views thus you get 0-7.

Instead set the listener outside the if (convertview == null) check.

Upvotes: 4

Gumbo
Gumbo

Reputation: 1746

You should override getCount:

@Override
public int getCount(){
    return songs.size();
}

Because it is essential for correct displaying the list, but returns 0 b default.

Upvotes: 0

Droidman
Droidman

Reputation: 11608

I ALWAYS get the correct song

of course since the code is correct

But the position(LogCat) is always from 0 up to 7...

This is due to how the ListView recycles its rows. 7 items are visible on the screen of your test device. See this post

Upvotes: 0

Related Questions