Scotty Allen
Scotty Allen

Reputation: 13377

NSString copy not copying?

  NSString *myString = @"sample string";
  NSString *newString = [myString copy];

If I set a breakpoint after these two lines, the pointer for myString is the same as the pointer for newString.

WTF? Isn't NSString copy supposed to return a pointer to a new object? Or am I missing something fundamental about how copy is supposed to work?

Upvotes: 11

Views: 12800

Answers (4)

R00We
R00We

Reputation: 1981

You can Allocate new variable like in sample

NSString *anotherString = [[NSString alloc] initWithString:originalString];

Upvotes: 2

SmallTitan
SmallTitan

Reputation: 21

It's a better practice to do copy the string value returned by a method, since the returned value maybe a mutable string object, and this value can be modified in other thread after returned by that method.

Upvotes: 1

kizzx2
kizzx2

Reputation: 19213

Think about this: NSMutableString is a subclass of NSString. When your property is declared as NSString, you don't expect it to change.

Consider, if you used retain and someone gave you an NSMutableString and then later on does change it, your class will be broken.

However, you may think that always copying is slow. So NSString's copy simply calls retain. NSMutableString's copy makes an actual copy.

It is usually better to give spit out an NSString * because people won't have to copy it all the time.

Upvotes: 8

stefanB
stefanB

Reputation: 79770

Since NSString is not mutable it might just internally increase ref count and be done with it.

When you release one of those NSStrings it might just decrement ref count - standard memory management.

Do you see any issues with that?

Upvotes: 12

Related Questions