CODEWITHSUNDEEP
c++inputpasswordsmasking
blaxc
blaxc

Reputation: 73

C++ password masking

i'm writing a code to receive password input. Below is my code... the program run well but the problem is other keys beside than numerical and alphabet characters also being read, for example delete, insert, and etc. can i know how can i avoid it? tq...

string pw="";
char c=' ';

while(c != 13) //Loop until 'Enter' is pressed
{
    c = _getch();
    if(c==13)
        break;

    if(c==8)
    {
        if(pw.size()!=0)   //delete only if there is input 
        {
            cout<<"\b \b";
            pw.erase(pw.size()-1);
        }
    }

    if((c>47&&c<58)||(c>64&&c<91)||(c>96&&c<123))  //ASCii code for integer and alphabet
    {
        pw += c;
        cout << "*";
    }
}

Upvotes: 3

Views: 4443

Answers (2)

N 1.1
N 1.1

Reputation: 12534

Filter using isalnum() for alpha-numeric or isalpha() for only alphabets.

Also, you are checking c == 13 twice, following will suffice.

while(1){
  //
  if(c == 13)
    break;
  //
}

if( isalnum(c) ){
  // 'c' is acceptable
}

Some assertion is failing during execution which throws that error.

Upvotes: 7

Marcelo Cantos
Marcelo Cantos

Reputation: 185970

If you have access to it, you are much better off using the GNU getpass function.

Upvotes: 2

Related Questions