CODEWITHSUNDEEP
c#refactoring
Brian
Brian

Reputation: 25834

Reducing Code Repetition: Calling functions with slightly different signatures

Suppose I have two functions which look like this:

public static void myFunction1(int a, int b, int c, string d)
{
    //dostuff
    someoneelsesfunction(c,d);
    //dostuff2
}

public static void myFunction2(int a, int b, int c, Stream d)
{
    //dostuff
    someoneelsesfunction(c,d);
    //dostuff2
}

What would be a good way to avoid repeated dostuff?

Ideas I've thought of, but don't like:

  1. I could make d an object and cast at runtype based on type, but this strikes me as not being ideal; it removes a type check which was previously happening at compile time.
  2. I could also write a private helper class that takes an object and write both signatures as public functions.
  3. I could replace dostuff and dostuff2 with delegates or function calls or something.

Upvotes: 7

Views: 561

Answers (5)

MusiGenesis
MusiGenesis

Reputation: 75286

I might do something like this:

public static void myFunction1(int a, int b, int c, string d)
{
    //dostuff
    someoneelsesfunction(c, d);
    //dostuff2
}

public static void myFunction2(int a, int b, int c, Stream d)
{
    string str = d.ReadEntireString(); // no such method, but basically
        // whatever you need to do to read the string out of the stream
    myFunction1(a, b, c, str);      
}

... and change the name of both functions to MyFunction (to take advantage of overloading, which is the same thing someoneelsesfunction() is doing.

NOTE: this solution would be impractical if the string contained in the Stream is ginormous. If so, you might want to do this the other way around: read the string d into a stream and call the override with the stream parameter.

Upvotes: 4

Pasi Savolainen
Pasi Savolainen

Reputation: 2500

Use Action to customize what a function does in some specific place.

public void myF1(int a, int b, int c, int d)
{
     internalF(a, b, { someelse1(c, d); }); 
}
public void myF2 (int a, int b, int c, Stream d)
{
     internalF(a, b, { someelse2(c, d); });
}
private void internalF (int a, int b, Action action)
{
    // dostuff
    action();
    // dostuff2
}

Upvotes: 3

twk
twk

Reputation: 3120

Eventually you can create 

public static void myFunction3(int a, int b, int c, Stream d, string e)

which will be called from function1 and function2 with d or e set to null. Then function3 would distinguish between calls to someoneelsesfunction(c,d). It is a possible solution, but for desperates :)

Upvotes: 2

Sam Holder
Sam Holder

Reputation: 32936

I'd start by extracting methods DoStuff and DoStuff2 and calling them from both functions.

You could then start to get funky by wrapping the block in another method and passing the someoneelsefunction to use to that method, but thats a step too far imho. you want things to be easy to read and change as well as not containing repetition.

Upvotes: 0

Reed Copsey
Reed Copsey

Reputation: 564433

Just refactor "doStuff" and "doStuff2" into separate methods.

They're obviously doing "stuff" that's separate from the "someoneelsesfunction" method, so they should be separate methods anyways. Each method should have one task, ideally.

This is even a supported refactoring in Visual Studio - just highlight the code in "dostuff", and right click, and choose Refactor->Extract Method.

Upvotes: 6

Related Questions