Andrew Lim
Andrew Lim

Reputation: 11

SQLiteException no such table

just starting out on Android and I am trying to create a simple app that has an SQLite database for collecting names and contact nos. I created a view activity that will display the contents in a list view using a simpleCursorAdapter (yes its depreciated but I have yet to cover using custom adapters. Anyway, so far the code compiles just fine. Its when I click on the button to start the view activity I get an

SQLite exception: no such table: clientTable (code 1): , while compiling: SELECT _id, name, mobile FROM clientTable.

below is the code for my database class

package com.example.ideahutquizz;

import android.content.Context;
import android.database.sqlite.SQLiteDatabase;
import android.database.sqlite.SQLiteOpenHelper;

public class ClientDatabase extends SQLiteOpenHelper {

    public static final String KEY_ROWID = "_id";
    public static final String KEY_NAME = "name";
    public static final String KEY_MOBILE = "mobile";

    public static final String DATABASE_NAME = "clientDatabase";
    public static final String TABLE_NAME = "clientTable";
    public static final int DATABASE_VERSION = 1;

    String CREATE_TABLE = "create table"
            + TABLE_NAME + "("
            + KEY_ROWID + "INTEGER PRIMARY KEY AUTOINCREMENT,"
            + KEY_NAME + "TEXT NOT NULL,"
            + KEY_MOBILE + "TEXT NOT NULL" + ")";

    public ClientDatabase(Context context) {
            super(context, DATABASE_NAME, null, DATABASE_VERSION);
        }

        @Override
        public void onCreate(SQLiteDatabase db) {
            // TODO Auto-generated method stub
            db.execSQL(CREATE_TABLE);
        }

        @Override
        public void onUpgrade(SQLiteDatabase db, int oldVersion, int newVersion) {
            // TODO Auto-generated method stub
            db.execSQL("DROP TABLE IF EXISTS " + TABLE_NAME);
            onCreate(db);
        }
}

and here is the code for the view activity

package com.example.ideahutquizz;

import android.content.Intent;
import android.database.Cursor;
import android.os.Bundle;
import android.support.v7.app.ActionBarActivity;
import android.view.Menu;
import android.view.MenuItem;
import android.view.View;
import android.view.View.OnClickListener;
import android.widget.Button;
import android.widget.ListView;
import android.widget.SimpleCursorAdapter;

public class ViewDataActivity extends ActionBarActivity {

    Button back;
    ListView clientList;
    SQLController clientDB;

    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_view_data);

        clientList = (ListView)findViewById(R.id.listView1);
        back = (Button)findViewById(R.id.button1);
        clientDB = new SQLController(this);
        clientDB.open();


        Cursor cursor = clientDB.readData();
        String[] from = new String[]{ClientDatabase.KEY_ROWID, ClientDatabase.KEY_NAME, ClientDatabase.KEY_MOBILE};
        int[] to = new int[]{R.id.textView_id, R.id.textView_name, R.id.textView_mobile};

        SimpleCursorAdapter adapter = new SimpleCursorAdapter(this, R.layout.listview_item_row, cursor, from, to);
        adapter.notifyDataSetChanged();
        clientList.setAdapter(adapter);

        back.setOnClickListener(new OnClickListener() {
            public void onClick(View v) {
                clientDB.close();
                Intent back = new Intent(ViewDataActivity.this, ControlPanel.class);
                startActivity(back);
            }
        });
    }

    @Override
    public boolean onCreateOptionsMenu(Menu menu) {
        // Inflate the menu; this adds items to the action bar if it is present.
        getMenuInflater().inflate(R.menu.view_data, menu);
        return true;
    }

    @Override
    public boolean onOptionsItemSelected(MenuItem item) {
        // Handle action bar item clicks here. The action bar will
        // automatically handle clicks on the Home/Up button, so long
        // as you specify a parent activity in AndroidManifest.xml.
        int id = item.getItemId();
        if (id == R.id.action_settings) {
            return true;
        }
        return super.onOptionsItemSelected(item);
    }
}

any help is much appreciated.

updated....

I altered the create table statement as follows but I am still getting the same error...

private static final String CREATE_TABLE = 
        "create table " + TABLE_NAME + "("
        + KEY_ROWID + " integer primary key autoincrement,"
        + KEY_NAME + " text not null,"
        + KEY_MOBILE + " text not null" + ")";

Upvotes: 0

Views: 2849

Answers (2)

Phantômaxx
Phantômaxx

Reputation: 38098

The table isn't created:

    String CREATE_TABLE = "create table"
        + TABLE_NAME + "("

Will produce this string:

    String CREATE_TABLE = "create tableclientTable("

You need to add a space after the create table:

    String CREATE_TABLE = "create table "
        + TABLE_NAME + "("

Same goes for the field names

So, at the end, the string will be:

String CREATE_TABLE = "CREATE TABLE " +
    TABLE_NAME + " (" +
    KEY_ROWID + " INTEGER PRIMARY KEY AUTOINCREMENT, " +
    KEY_NAME + " TEXT NOT NULL, " +
    KEY_MOBILE + " TEXT NOT NULL" + ")";

Upvotes: 1

Joachim Isaksson
Joachim Isaksson

Reputation: 180887

Your CREATE TABLE statement will fail due to some missing spaces;

String CREATE_TABLE = "create table"
        + TABLE_NAME + "("
        + KEY_ROWID + "INTEGER PRIMARY KEY AUTOINCREMENT,"
        + KEY_NAME + "TEXT NOT NULL,"
        + KEY_MOBILE + "TEXT NOT NULL" + ")";

...will result in something like

create tableclientTable(
    _idINTEGER PRIMARY KEY AUTOINCREMENT,
    nameTEXT NOT NULL,
    mobileTEXT NOT NULL)

...which will cause a syntax error and not create the table.

Upvotes: 1

Related Questions