CODEWITHSUNDEEP
springautowiredtransactionalproxy-classescglib
Aaron Digulla
Aaron Digulla

Reputation: 328780

Spring Java config, @Autowire vs. Constructor Injection, @Transactional and CGLIB

We've been using @Autowired plus Java-based Spring configuration with some success but now, we're losing control. Everyone is starting to add autowired dependencies everywhere, creating cycles and strange bugs.

So we are considering using constructor injection and autowiring of Spring configurations.

Old:

class Bean {
   @Autowired Foo foo;
}

@Configuration
@Import( FooCfg.class )
class BeanCfg {
   @Bean public Bean bean() { return new Bean(); }
}

New:

class Bean {
   public Bean(Foo foo) {...}
}

@Configuration
class BeanCfg {
   @Autowired FooCfg fooCfg;
   @Bean public Bean bean() { return new Bean(fooCfg.foo()); }
}

This works pretty well (and it drives people to split beans instead of creating monsters with 10+ constructor arguments).

But it fails when Bean has a method annotated with @Transactional since CGLIB then tries to create a proxy which fails since it can't find a no-argument constructor.

What's the solution for this?

Upvotes: 3

Views: 6448

Answers (1)

M. Deinum
M. Deinum

Reputation: 125232

You have a couple of possible of solutions

  1. Introduce interfaces your classes
  2. Upgrade the Spring Version to at least 4.0
  3. Add protected no-arg constructor

Introduce Interfaces

When introducing interfaces for your classes you can drop the usage of CgLib. Spring will then be able to use JDK Dynamic Proxies which work around interfaces. It creates a proxy around an already existing bean instance and that proxy implements all the interfaces of the class it is wrapping. That way it doesn't matter if your class has a no-arg constructor or not.

Upgrade to Spring 4

In Spring 4.0 support was added to allow proxying of classes with a missing no-arg constructor (See SPR-10594). To enable this upgrade your Spring version and add Objenesis to your classpath, Spring 4 comes with its own repacked cglib version so that shouldn't be needed anymore.

One thing to note is that you should have a constructor with no logic if you do null checks or init logic in the constructor it might fail in the case where cglib creates an instance. I would suspect that it pass null to all the constructor arguments (or some default for primitives).

Added protected no-arg constructor

Cglib needs to be able to create an instance which is used to wrap the actual class. It should be enough to have a protected constructor in your classes so that cglib can call it.

Upvotes: 5

Related Questions