CODEWITHSUNDEEP
c#javastringlogicindexof
jcgarciam
jcgarciam

Reputation: 392

IndexOf method returns 0 when it should had return -1 in C# / Java

A friend of mine came to me with this strange behavior which i can't explain, any insight view would be appreciated.

Im running VS 2005 (C# 2.0), the following code show the behavior

int rr = "test".IndexOf("");
Console.WriteLine(rr.ToString());

the above code, print "0" which clearly show it should have return -1

This also happen in Java where the following Class show the behavior:

public class Test{
 public static void main(String[] args){
   System.out.println("Result->"+("test".indexOf("")));
 }
}

Im running Java 1.6.0_17

Upvotes: 7

Views: 9918

Answers (8)

Jorge Vargas
Jorge Vargas

Reputation: 6942

Just for the fun of it. It also works like that in python

>>> "test".startswith("")
True
>>> "test".index("")
0

Python throws a ValueError instead of the -1 that is nice.

>>> "test".index('r')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ValueError: substring not found

Upvotes: 1

Jorge Vargas
Jorge Vargas

Reputation: 6942

More fun php actually does a way better job!

php -r "print strpos('test','');"
PHP Warning:  strpos(): Empty delimiter. in Command line code on line 1

Upvotes: 1

Justin Ardini
Justin Ardini

Reputation: 9866

0 is correct. The Javadocs point out that indexOf works as follows:

The integer returned is the smallest value k such that:

 this.startsWith(str, k)

Any string starting with "" is equal to the original string (and every string starts with ""), so the smallest k for str = "" is always 0.

Upvotes: 6

Josh Lee
Josh Lee

Reputation: 177855

This is not an exception to the rule, but rather a natural consequence of how indexOf and startsWith are defined.

You’re claiming that "test".indexOf("") should return -1. This is essentially equivalent to the claim that "test".startsWith("") should return false. Why is this? Although this case is specifically addressed in the documentation as returning true, this is not just an arbitrary decision.

How would you decide "test".startsWith("te"), for example? The simplest way is to use recursion. Since both strings start with the character 't', you call "est".startsWith("e") and return the result. Similarly, you will call "st".startsWith("") and return the result. But you already know that the answer should be true, so that is why every string starts with "".

Upvotes: 10

Fredrik M&#246;rk
Fredrik M&#246;rk

Reputation: 158389

Quote from the C# documentation:

If value is Empty, the return value is 0.

The behavior that you describe is entirely as expected (at least in C#).

Upvotes: 21

Rubys
Rubys

Reputation: 3207

Think of it this way: IndexOf, when looking for a string, will start at position 0, try to match the string, if it doesn't fit, move on to position 1, 2, etc. When you call it with an empty string, it attempts to match the empty string with the string starting at position 0 with length 0. And hooray, nothing equals nothing.

Side note: There's no real reason to use ToString when you're using Console.Write/WriteLine. The function automatically calls the ToString method of the object in question. (Unless overloading ToString)

Upvotes: 3

glebm
glebm

Reputation: 21110

It should return 0. You are looking for the first occurrence of an empty string, right? :)

Upvotes: 2

Marc Gravell
Marc Gravell

Reputation: 1064104

0 is correct. Start at position zero and you can (trivially) match a zero-length string. Likewise, "" contains "".

Upvotes: 11

Related Questions