CODEWITHSUNDEEP
ember.jsember-cli
Robert Neville
Robert Neville

Reputation: 264

ember-cli & common route and controller behavior options: Subclass, Mixin or initializer (service)?

I have properties and methods I want exposed to most/all instances of a class (i.e. all but a handful of routes, controllers, whatever). There seems to be multiple ways to accomplish this and I'm looking for guidance for best practices here.

More specifically, I've created a property on my application controller to hold a user session object. I want all other controllers to expose this data as if I had typed:

needs: ['application'],
userSession: Ember.computed.alias('controllers.application.userSession')

directly into the controller.

Further, I want to override all routes (other than the login route and maybe a couple more) implementations of beforeModel to check for the presence of userSession and redirect to the login route if absent.

This is being implemented in ember-cli FYI. So, that being the case, what's the "right" approach here? Do I try to inject these changes via initializers/services? Do I create mix-ins to do this stuff (I'm not a fan of having to remember to do that every time someone working on this does ember g controller that they then have to remember to add the mixin).

Upvotes: 0

Views: 337

Answers (1)

Leeft
Leeft

Reputation: 3837

Sounds very much like the use of an initializer and a service is the best approach (them being split up makes for cleaner code). The initializer is just the code to load the service, the service does the hard work. The initializer should look something like:

import AuthService from '../services/auth';

export default {
  name: 'auth-service',
  initialize: function( container, app ) {
    app.register( 'service:auth', AuthService, { singleton: true } );
    app.inject( 'controller', 'auth', 'service:auth' );
    app.inject( 'route', 'auth', 'service:auth' );
  }
};

This then injects auth into every controller and route, and you should move the userSession from your application to the service.

My auth service is too big (and in my case: too specific, as it uses Firebase) to be quoting it here. I gave the gist of it in an answer yesterday: Short delay when trying to run redirect with ember route with firebase authentication

And as you mentioned it: people don't strictly need to remember to include mixins as you can override the blueprint that is used when someone does ember generate: http://www.ember-cli.com/#generators-and-blueprints

Upvotes: 2

Related Questions