CODEWITHSUNDEEP
androidandroid-fragmentsandroid-actionbarandroid-optionsmenu
SalicBlu3
SalicBlu3

Reputation: 1914

OptionsMenu of Fragments in Viewpager showing each other's Buttons

I've got three fragments in a viewpager.

Two of these fragments have their own version of the onCreateOptionsMenu method:

 @Override
public void onCreateOptionsMenu(Menu menu, MenuInflater inflater) {
    super.onCreateOptionsMenu(menu, inflater);

    // Set up 1 action button
    inflater.inflate(R.menu.home_snapshot_add, menu);
}

@Override
public void onCreateOptionsMenu(Menu menu, MenuInflater inflater) {
    super.onCreateOptionsMenu(menu, inflater);

    // Set up 2 action buttons
    inflater.inflate(R.menu.home_snapshot_send, menu);
}

The home activity has a basic onCreateOptionsMenu method:

    @Override
public boolean onCreateOptionsMenu(Menu menu) {
    return false;
}

In the onCreate method, each fragment calls the method:

setHasOptionsMenu(true);

Each of the menu items have the tag:

android:showAsAction="always"

Seems like as I open the Activity, all three buttons appear. However, when I scroll through them, the wrong ones magically disappear. It feels like the activity is calling every Fragment's options menu on Activity creation and then changes the menu appropriately when I swipe left and right. I've checked the menus but not sure what's wrong. Anything you reckon I need to check? I'm a little out of ideas.

Thanks!

Upvotes: 16

Views: 10933

Answers (2)

Daniel Ben
Daniel Ben

Reputation: 185

I've used this and it has worked for me:

//In your Fragment
@Override
public void onResume() {
    super.onResume();
    setHasOptionsMenu(isVisible());

}

Upvotes: 1

Nikola Despotoski
Nikola Despotoski

Reputation: 50538

In your ViewPager's OnPageChangeListener and after setting the adapter to the ViewPager, have this:

@Override
public void onPageSelected(int position){
   invalidateFragmentMenus(position);
}


private void invalidateFragmentMenus(int position){
   for(int i = 0; i < mViewPagerFragentAdapter.getCount(); i++){
      mViewPagerAdapter.getItem(i).setHasOptionsMenu(i == position);
   }
   invalidateOptionsMenu(); //or respectively its support method.
}

After setting your fragment adapter call the same method with following argument:

invalidateFragmentMenus(mViewPager.getCurrentItem());

The above statements will prevent all other fragments not to receive call on onCreateOptionsMenu() method when invalidateOptionsMenu() is called, only the currently visible fragment will receive and be able to populate the options menu.

Upvotes: 20

Related Questions