CODEWITHSUNDEEP
objective-cmacoscocoaosx-yosemitensstatusitem
Luke
Luke

Reputation: 5076

NSStatusBarButton keep highlighted

As of OS X 10.10 most of NSStatusItem has been deprecated in favour of the button property, which consists of an NSStatusBarButton. It should work like a normal button but unfortunately the cell and setCell methods in NSStatusButton have also been deprecated. As a result of this I'm struggling to find a way to keep the button highlighted after it's clicked (Normally the button is highlighted on mouse down, and unhighlighted on mouse up. I want to keep it highlighted after mouse up).

Calling [NSStatusButton setHighlighted:] in its action doesn't work because it seems to unhighlight itself once the mouse is up. On the other hand, using a delay to call it on the next loop i.e. [self performSelector: withDelay:] causes the highlight to flash in a rather unsightly way. It works, but doesn't look nice.

Setting the button type to NSToggleButton removes the highlight entirely and instead highlights the template image which was odd.

Those were the only methods I could think of. Is there anyway to override this NSButtonCell mouseUp behaviour?

Upvotes: 17

Views: 3767

Answers (10)

erikvdplas
erikvdplas

Reputation: 551

Swift 3 version of Manfred Urban's answer. Works on El Capitan.

extension NSStatusBarButton {

   public override func mouseDown(_ event: NSEvent) {

        if event.modifierFlags.contains(NSControlKeyMask) {
            self.rightMouseDown(event)
            return
        }
    
        self.highlight(true)
    
        (self.target as? TrivialTargetClass)?.togglePopover()
    }
}

Don't forget to set the buttons highlight property to false again if appropriate.

Upvotes: 7

Saket
Saket

Reputation: 3076

Here's a Swift 5 version of @erikvdplas's answer. I tested this on macOS 11.4 Big Sur.

extension NSStatusBarButton {
    public override func mouseDown(with event: NSEvent) {
        super.mouseDown(with: event)
        self.highlight((NSApp.delegate as! YourAppDelegateClass).popover.isShown)
    }
}

Upvotes: 1

Sam Soffes
Sam Soffes

Reputation: 14935

Anton's solution is perfect. Here it is in Swift 3:

NSEvent.addLocalMonitorForEvents(matching: .leftMouseDown) { [weak self] event in
    if event.window == self?.statusItem.button?.window {
        // Your action:
        self?.togglePopover(self?.statusItem.button)
        return nil
    }

    return event
}

I added an observer for NSApplicationWillResignActive to close the popover and set the button's isHighlighted to false.

Upvotes: 2

Valentin Shergin
Valentin Shergin

Reputation: 7334

TL;DR: Any NSButton instance (with NSImage that has template=YES) inside NSStatusItem property visually looks exactly like NSStatusBarButton. You can control their highlight property as you want.

If you want to control highlight of your NSStatusItem manually and at the same time get all appearance benefits from using NSStatusBarButton you can use slightly different approach. You can create your own NSButton instance which has its own property highlight that is completely under your control. Then you have to create NSImage instance and set its template property to YES. Then you have to add this button to [NSStatusItem view] (yes, which is softly deprecated) or even as subview to system created [NSStatusItem button]. After this you have to draw background of NSStatusItem manually with [NSStatusItem drawStatusBarBackgroundInRect:withHighlight:] (which is also deprecated, oh).

With this approach, you can combine full control of look and feel of your NSStatusItem and get automatic styling of button's image.

Upvotes: 3

Anton Simakov
Anton Simakov

Reputation: 303

Here is one more option. Don't set NSStatusItem's action property. Instead add a local event monitor:

[NSEvent addLocalMonitorForEventsMatchingMask:(NSLeftMouseDown | NSRightMouseDown)
                                      handler:^NSEvent *(NSEvent *event) {
                                          if (event.window == self.statusItem.button.window) {
                                              [self itemClicked];
                                              return nil;
                                          }
                                          return event;
                                      }];

Then in -itemClicked highlight the button using highlight: method:

- (void)itemClicked {
    [self.statusItem.button highlight:YES];
    // Do other stuff 
}

To unhighlight just call button's highlight:NO where you need.

Upvotes: 15

DarezGhost
DarezGhost

Reputation: 59

If you schedule the highlighting of the button in for a subsequent execution on the main thread everything seems to work out. This does work on El Capitan as well. 

    if self.appPopover.shown {
        self.appPopover.performClose(sender)
    } else {
        if let button = statusItem.button {
            // set the button's highlighted property to true
            dispatch_async(dispatch_get_main_queue(), {
                button.highlighted = true
            })

            appPopover.showRelativeToRect(button.bounds, ofView: button, preferredEdge: NSRectEdge.MinY)
        }
    }

This does work, but you might notice a little flicker due to the button state being changed from ON to OFF and then ON again. The OFF happens because of the popover display. So, to fix that, just move the appPopover.showRelativeToRect() call inside the dispatch_async() block, right after setting the button highlighted.

Upvotes: 0

Manfred Urban
Manfred Urban

Reputation: 449

Struggling with this issue myself, I discovered that overwriting mouseDown: in a category on NSStatusBarButton works:

#import "MUTargetClass.h"

@implementation NSStatusBarButton (Additions)

- (void)mouseDown:(NSEvent *)theEvent
{
    // Relay CTRL+Click to perform a right click action
    if(theEvent.modifierFlags & NSControlKeyMask)
    {
        [self rightMouseDown:theEvent];
        return;
    }

    // Handle highlighting
    [self setHighlighted:YES];

    // Perform action on target
    [(MUTargetClass *)self.target actionSelector:self];
}

@end

MUTargetClass could then for example implement:

#import "NSStatusBarButton+Additions.h"

@implementation MUTargetClass

[…]
    self.statusItem = [[NSStatusBar systemStatusBar] statusItemWithLength:NSVariableStatusItemLength];
    NSStatusBarButton *button = [self.statusItem button];
    [button setTarget:self];
[…]

- (void)actionSelector:(id)sender
{
    // Whatever behavior a click on the button should invoke
}

[…]
    // Reset button's highlighting status when done
    [[self.statusItem button] setHighlighted:NO];
[…]

@end

Note that the functionality of CTRL+clicking the button is getting lost in the mouseDown: -override. As shown above, it can be restored by relaying the event to rightMouseDown:.

A simpler way of having the action called would be something along the lines of [self.target performSelector:self.action] in the category and [self.statusItem setAction:@selector(actionSelector:)] in the target class, however this may cause a leak in ARC projects.

Edit: This works on El Capitan, too.

Upvotes: 4

Luke
Luke

Reputation: 5076

I added a subview to the status item, and inside that view I added event handlers for mouseDown etc. which called [[statusItem button] highlight:true]. As it turns out setHighlighted: doesn't do the same thing as highlight:.

NSArray *array = [NSArray arrayWithObjects:[statusItem button], [self statusItemView], nil];
[[[statusItem button] superview] setSubviews:array];
//Highlight like so:
[[statusItem button] highlight:true];

EDIT: As of El Capitan this method no longer works, and neither does statusItem.button.highlight = true either 😀🔫

Upvotes: 4

Xhacker Liu
Xhacker Liu

Reputation: 1618

Luke’s answer is great. I’m just sharing my implementation based on that.

NSButton *button = [[NSButton alloc] initWithFrame:self.statusItem.button.frame];
button.alphaValue = 0;
NSArray *array = @[self.statusItem.button, button];
self.statusItem.button.superview.subviews = array;

[button sendActionOn:(NSLeftMouseDownMask | NSRightMouseDownMask)];
button.target = self;
button.action = @selector(statusItemClicked);

Upvotes: 0

nek023
nek023

Reputation: 11

One idea is swizzling isHighlighted of NSStatusBarButtonCell and return an arbitrary value. https://gist.github.com/questbeat/3244601c8dc779484076

But the problem is whether Apple's review team allows this approach or not...

Upvotes: 1

Related Questions