francisbyrne
francisbyrne

Reputation: 187

Why isn't Meteor Collection behaving reactively?

TLDR: I want to track the dependencies of a Meteor Collection to work out why my template helper isn't reactive.

I have been trying to create a reactive checklist component in Meteor that can be reused in different templates.

Template:

<template name="checklist">
  <ul>
    {{#each items}}
    <li>
      <label>
        <input 
          type="checkbox" 
          value="{{value}}" 
          checked="{{isChecked}}" 
          data-id="{{_id}}" 
        /> {{name}}
      </label>
      <span>&nbsp;&nbsp;&nbsp; Status: {{status}}</span>
    </li>
    {{/each}}
  </ul>
      {{checkedIds}}
</template>

Javascript:

if (Meteor.isClient) {

  var list;

  /**
   * 
   * Creates a Checklist instance, with a local collection that maintains the status
   * of all checkboxes: 'checked', 'unchecked' or 'indeterminate'
   *
   */
  function createChecklist() {

    var _checked = new Meteor.Collection(null),

    check = function(id) {
      return _checked.upsert({_id: id}, {_id: id, status: 'checked'});
    },

    getStatus = function(id) {
      var item = _checked.findOne({_id: id})
      return item && item.status;
    },

    isChecked = function(id) {
      return _checked.find({_id: id, status: 'checked'}).count() > 0;
    },

    getCheckedIds = function() {
      return _checked.find({status: 'checked'}).map(function(doc){return doc._id});
    },

    toggle = function(id) {
      if ( isChecked(id) )
        return uncheck(id);
      else
        return check(id);
    },

    uncheck = function(id) {
      return _checked.upsert({_id: id}, {_id: id, status: 'unchecked'});
    };

    return Object.freeze({
      'check': check,
      'getCheckedIds': getCheckedIds,
      'getStatus': getStatus,
      'isChecked': isChecked,
      'toggle': toggle,
      'uncheck': uncheck
    });
  }

  Template.checklist.helpers({
    items: [
      {_id: 0, name: 'Item 1', value: 10},
      {_id: 1, name: 'Item 2', value: 20},
      {_id: 2, name: 'Item 3', value: 40},
      {_id: 3, name: 'Item 4', value: 20},
      {_id: 4, name: 'Item 5', value: 100},
      ],
    isChecked: function() {
      return list.isChecked(this._id);
    },
    status: function() {
      return list.getStatus(this._id);
    },
    checkedIds: function() {
      return EJSON.stringify(list.getCheckedIds());
    }
  });

  Template.checklist.events({
    'change [type=checkbox]': function(e, tmpl) {
      var id = e.target.dataset.id;
      list.toggle(id);
    }
  });

  Template.checklist.created = function() {
    list = createChecklist();
  }
}

You'll notice that the checkedIds helper is reactively updating whenever you check a box. However, the status helper is not reactively updating.

I am trying to:

  1. Track the dependencies of the _checked collection in order to work out if the status helper has been added as a Computation.

  2. Understand why this helper is not reactively updating.

If anyone could help with either of these items, I'd be really grateful.

So far I have done the following:

  1. Confirmed that Deps.active = true inside the status helper (and its function calls)
  2. Put the following code inside the status helper to check if it is invalidated when I tick a checkbox (it is never invalidated):

    var comp = Deps.currentComputation; comp.onInvalidate(function() { console.track(); });

Upvotes: 0

Views: 106

Answers (1)

user54580
user54580

Reputation: 395

The _id is stored as a string in Mongo.

Change to:

getStatus = function(id) {
  var item = _checked.findOne({_id: String(id)})
  return item && item.status;
},

Upvotes: 1

Related Questions