CODEWITHSUNDEEP
javascriptboolean
Shiva Traanman
Shiva Traanman

Reputation: 175

What is going wrong here?

i made this little script to learn javascript. but i keep getting unexpected token switch.. but hoe do is set switch the corect way??

html:

<p id="new">test<p>
    <input id="button" type="submit" name="button" value="enter" />

js:

var switch = true;

if (switch == false){
document.getElementById('button').onclick = function() {
document.getElementById("new").innerHTML = "Mijn Naam!";
    var switch = true;
};
} else {
document.getElementById('button').onclick = function() {
document.getElementById("new").innerHTML = "shiva";
    var switch = false;
};
}

Upvotes: 0

Views: 61

Answers (2)

FredL
FredL

Reputation: 1045

how about:

<p id="new">test<p>
<input id="button" type="submit" name="button" value="enter" />

var clicked = false;

document.getElementById('button').onclick = function() {
  document.getElementById("new").innerHTML = clicked ? "shiva" : "Mijn Naam!";
  clicked = !clicked;
};

Upvotes: 4

stanleyxu2005
stanleyxu2005

Reputation: 8231

switch is a reserved word. You should use some variable name else.

By the way, your code is possible to be compressed as follows:

var switchOn = true;

document.getElementById('button').onclick = function() {
    document.getElementById("new").innerHTML = 
        switchOn ? "shiva" :"Mijn Naam!";
    switchOn = !switchOn;
}

Upvotes: 0

Related Questions