CODEWITHSUNDEEP
pythonpython-2.7
MartinP
MartinP

Reputation: 535

Simpler solution to find changes in lists with dicts

I'm looking for a better and simpler solution to find changes between two nested lists within dicts, archived and actual data.

I want to find:

self.l_dicts_arch - archived data

self.l_dicts_actual - actual data

Here's my function:

def check(self):
    for item in self.l_dicts_arch: 
        if item in self.l_dicts_actual:#remove correct data
            self.l_dicts_actual.remove(item) 
        elif item not in l_dicts_actual:
            for item2 in l_dicts_actual:
                if item['id']==item2['id']:#display and remove data with error
                    print 'Found error in data'
                    print 'from first list', item
                    print 'from second list',item2
                    actual_list.remove(item2)
                else:
                    print 'This item was removed from actual list'#display deleted data
                    print item
    if len(self.l_dicts_actual)!=0:
        print 'This item was added on actual list'
        for item in self.l_dicts_actual:
            print item

Upvotes: 0

Views: 103

Answers (1)

FunkySayu
FunkySayu

Reputation: 8061

For the following sets :

actual = [{'id' : 4, 'data' : 'foo'}, {'id' : 5, 'data' : 'toto'}, {'id' : 7, 'data' : 'tagada'}] arch = [{'id' : 4, 'data' : 'foo'}, {'id' : 5, 'data' : 'toto2'}, {'id' : 6, 'data' : 'tata'}]

Here are some solutions :

  • Items deleted (finding on 'id' tag) :

deleted = filter(lambda x: not x['id'] in map(lambda x: x['id'], actual), arch)

  • Added data (finding on 'id' tag) :

added = filter(lambda x: not x['id'] in map(lambda x: x['id'], arch), actual)

  • Modified items :

modified = filter(lambda x: not x in arch, filter(lambda x: x['id'] in map(lambda x: x['id'], arch), actual))

A cool code could be something like this :

def check(arch, actual): id_actual = map(lambda x: x['id'], actual) id_arch = map(lambda x: x['id'], arch) deleted = filter(lambda x: not x['id'] in id_actual, arch) added = filter(lambda x: not x['id'] in id_arch, actual) modified = filter(lambda x: not x in arch, filter(lambda x: x['id'] in id_arch, actual))

EDIT: I think you can optimize that, I'm looking for another solution...

Upvotes: 1

Related Questions