CODEWITHSUNDEEP
angularjsangularjs-ng-repeat
Coyolero
Coyolero

Reputation: 2433

How to set a boolean flag to collapse/expand a row with ng-repeat

I have this plunker code.

What I'm trying to do, is to display the gray box one time per row.

To achieve this, I thought to modify the partition filter in order to return a JSON to add it a new property by row to know if the gray box is expanded or not.

But, I could Not successfully return a JSON.

Do you know how to modify the filter to return a JSON or a better way to show the gray box by row?

Related questions:

Update 1

The issue could be easily resolved by using the correct scope for the ng-repeat for the row without modifying the filter, thanks to @m59.

http://plnkr.co/edit/eEMfI1lv6z1MlG7sND6g?p=preview

Update 2

Live Demo

If I try to modify the item, it seems the ng-repeat would be called again losing the props values.

  <div ng-repeat="friendRow in friends | partition:2" 
       ng-init="props = {}">
    <div ng-repeat="item in friendRow" 
         ng-click="collapse(item)" 
         ng-class="{myArrow: showArrow}">
      {{item.name}} {{item.age}} years old.
      <div>{{item.name}}</div>
    </div>
    <div collapse="!props.isExpanded">
      some content
      <br/>
      <input type="text" ng-model="currentItem.name">
    </div>
  </div>

js

  $scope.collapse = function(item){
     this.props.isExpanded  = !this.props.isExpanded;
     this.showArrow = !this.showArrow;
     $scope.currentItem = item;
  };

This causes the gray box to collapse each time the item is modified. Any clue?

Upvotes: 0

Views: 13464

Answers (1)

m59
m59

Reputation: 43755

I've updated my code/answer regarding partitioning data. It's important to fully understand all of that before deciding on an approach to your project.

The problem you have in your plnkr demo is that you're modifying the parent $scope and not the scope of the ng-repeat for that row.

Just set a flag on the row and toggle it when clicked:

Live Demo

<div 
  class="row" 
  ng-repeat="friendRow in friends | partition:2"
  ng-init="isExpanded = false" 
  ng-click="isExpanded = !isExpanded"
>
  <div ng-repeat="item in friendRow">
    {{item.name}} {{item.age}} years old.  
  </div>
  <div collapse="!isExpanded">
    some content
  </div>
</div>

To access the correct scope within a function in the controller, you can use the this keyword instead of $scope. this will refer to the scope the function is called from, whereas $scope refers to the scope attached to the element with ng-controller (a parent of the ng-repeat scopes you want to target).

<div 
  class="row" 
  ng-repeat="friendRow in friends | partition:2" 
  ng-click="collapse()"
>

JS:

$scope.collapse = function() {
   this.isExpanded  = !this.isExpanded;
};

If you want to keep the ng-click directive on the item element instead of putting it on the row element as I have done, then you're dealing with another child scope because of that inner ng-repeat. Therefore, you will need to follow the "dot" rule so that the child scope can update the parent scope where the collapse directive is. This means you need to nest isExpanded in an object. In this example, I use ng-init="props = {}", and then use props.isExpanded. The dot rule works because the children share the same object reference to props, so the properties are shared rather than just copied, just like in normal JavaScript object references.

Live Demo

<div 
  class="row"
  ng-repeat="friendRow in friends | partition:2" 
  ng-init="props = {}"
>
  <div ng-repeat="item in friendRow" ng-click="collapse()">
    {{item.name}} {{item.age}} years old.
  </div>
  <div collapse="!props.isExpanded">
    some content
  </div>
</div>

JS:

$scope.collapse = function(){
   this.props.isExpanded  = !this.props.isExpanded;
};

Update

We keep going through more and more issues with your project. You really just need to experiment/research and understand everything that's going on on a deeper level, or it will just be one question after another. I'll give it one last effort to get you on the right track, but you need to try in the basic concepts and go from there.

You could get past the issue of props reinitializing by putting $scope.expandedStates and then passing the $index of the current ng-repeat to your function (or just using it in the view) and setting a property of expandedStates like $scope.expandedStates[$index] = !$scope.expandedStates[$index]. With the nested ng-repeat as it is, you'll need to do $parent.$index so that you're associating the state with the row rather than the item.

However, you'll then have another problem with the filter: Using my old partition code, the inputs inside the partitions are going to lose focus every time you type a character. Using the new code, the view updates, but the underlying model will not. You could use the partition filter from this answer to solve this, but from my understanding of that code, it could have some unexpected behavior down the road and it also requires passing in this as an argument to the filter. I don't recommend you do this.

Filters are meant to be idempotent, so stabilizing them via some kind of memoization is technically a hack. Some argue you should never do this at all, but I think it's fine. However, you definitely should ONLY do this when it is for display purposes and not for user input! Because you are accepting user input within the partitioned view, I suggest partitioning the data in the controller, then joining it back together either with a watch (continuous) or when you need to submit it.

$scope.partitionedFriends = partitionFilter($scope.friends, 2);

$scope.$watch('partitionedFriends', function(val) {
  $scope.friends = [].concat.apply([], val);
}, true); // deep watch

Upvotes: 3

Related Questions