CODEWITHSUNDEEP
javaexceptionconstructor
fredoverflow
fredoverflow

Reputation: 263128

Exceptions in constructors

In C++, the lifetime of an object begins when the constructor finishes successfully. Inside the constructor, the object does not exist yet.

Q: What does emitting an exception from a constructor mean?

A: It means that construction has failed, the object never existed, its lifetime never began. [source]

My question is: Does the same hold true for Java? What happens, for example, if I hand this to another object, and then my constructor fails?

Foo()
{
    Bar.remember(this);
    throw new IllegalStateException();
}

Is this well-defined? Does Bar now have a reference to a non-object?

Upvotes: 7

Views: 958

Answers (3)

Tadeusz Kopec for Ukraine
Tadeusz Kopec for Ukraine

Reputation: 12403

This code is not exception safe and neither would be exception safe in C++. It's same bug regardless of the language you use.

Upvotes: 0

Joachim Sauer
Joachim Sauer

Reputation: 308031

The object exists, but it's not been initialized properly.

This can happen whenever this leaks during construction (not just when you throw an exception).

It's a very problematic situation, because some commonly assumed guarantees don't hold true in this situation (for example final fields could seem to change their value during construction).

Therefore you should definitely avoid leaking this in the constructor.

This IBM developerWorks article describes the precautions to take when constructing objects and the reasoning behind those precautions. While the article discusses the subject in the light of multi-threading, you can have similar problems in a single-threaded environment when unknown/untrusted code gets a reference to this during construction.

Upvotes: 8

John
John

Reputation: 373

You should never open resources like a file writer in your constructor. Create a init method instead and do it from there. Then you're safe.

Upvotes: 1

Related Questions