CODEWITHSUNDEEP
javamysqlsqljdbcprepared-statement
k_rollo
k_rollo

Reputation: 5472

SELECT with WHERE using PreparedStatement

I have this method that selects movie showtimes by movie ID from a MySQL database and puts them in a Time[]. However, it is throwing a syntax exception near '? ORDER BY schedule_id' according to the trace.

public Time[] getShowTimes(int movieId) {
    List<Time> list = new ArrayList<Time>();

    try {
        sql = "SELECT schedule_time FROM schedule WHERE movie_id = ? ORDER BY schedule_id";

        ps = conn.prepareStatement(sql);
        ps.setInt(1, movieId);

        rs = ps.executeQuery(sql);

        while(rs.next()) {
            list.add(rs.getTime(1));
        }

    } catch(SQLException se) {
        se.printStackTrace();
    }

    Time[] times = new Time[list.size()];
    times = list.toArray(times);

    return times;
}

I followed this example (if that helps). What could be wrong?

Upvotes: 1

Views: 90

Answers (1)

rgettman
rgettman

Reputation: 178243

You are calling the executeQuery(String) method in your PreparedStatement, and that call is just inherited from Statement. But Statement just executes the query without any PreparedStatement placeholder semantics, hence the error.

Instead, you want to call the executeQuery() (no arguments) method. The SQL has already been prepared, and all placeholders have been assigned values, so the SQL argument string is not needed again.

rs = ps.executeQuery();

Upvotes: 2

Related Questions