CODEWITHSUNDEEP
javagenericslegacy-code
Paul Crowley
Paul Crowley

Reputation: 1714

How to avoid Eclipse warnings when using legacy code without generics?

I'm using JSON.simple to generate JSON output from Java. But every time I call jsonobj.put("this", "that"), I see a warning in Eclipse:

Type safety: The method put(Object, Object) belongs to the raw type HashMap. References to generic type HashMap should be parameterized

The clean fix would be if JSONObject were genericized, but since it isn't, I can't add any generic type parameters to fix this. I'd like to switch off as few warnings as possible, so adding "@SuppressWarnings("unchecked")" to lots of methods is unappealing, but do I have any other option besides putting up with the warnings?

Upvotes: 7

Views: 4477

Answers (3)

Kip
Kip

Reputation: 109413

Here's one option. It's a bit ugly, but allows you to scope the the suppressed warning to only that individual operation.

Add a function which does the unchecked cast, and suppress warnings on it:

@SuppressWarnings("unchecked")
private final static Map<Object,Object> asMap(JSONObject j)
{
  return j;
}

Then you can call it without compiler warnings:

asMap(jsonobj).put("this", "that");

This way, you can be sure that you aren't suppressing any warnings that you actually want to see.

Upvotes: 7

Chris Lercher
Chris Lercher

Reputation: 37778

Write some helper methods, or wrapper classes for the library. Add the @SuppressWarnings("unchecked") only to those helpers. Then use the helpers to perform the interaction with the library.

Upvotes: 4

Omry Yadan
Omry Yadan

Reputation: 33646

you can have a per project compiler settings and you can change those warnings to ignore.

Upvotes: 4

Related Questions