CODEWITHSUNDEEP
c#variablesparametersarguments
Jokuc
Jokuc

Reputation: 45

Assign multiple values to one object(?)

Note: I am somewhat of a beginner to C#.

I'm working on a little game that will have a bunch of different levels. Each level has its own class that contains variables (and other irrelevant code). Since I need to pass these values to the main class (my form) I have made them all into methods that returns the value I want (since I can't come up with a better solution). example:

class Level01
{
    public int Boxes() { return 3; }
    public int MaxPoints() { return 46; }
    public int Health() { return 63; }
    public int[,] SolidBoxes()
    {
        int[,] position = new int[Boxes(), Boxes()];
        position[1, 1] = 1;
        return position;
    }
}

When I access these values from my form class I do 

int boxes;
int maxPoints;
int health;
int[,] solidBoxes;

void readLevelData() //Starts each new level
{
    //Reads the correct level
    switch (levelNo)
    {
        case 1: 
        setValues(Lvl01.Boxes(), Lvl01.MaxPoints(), Lvl01.Health(), Lvl01.SolidBoxes()); 
        break;
        //The same case 2:, 3: for Level02,03..
    }
}

void setValues(int getBoxes, int getMaxPoints, int getHealth, int[,] getSolidBoxes)
{
    boxes = getBoxes;
    maxPoints = getMaxPoints;
    health = getHealth;
    solidBoxes = getSolidBoxes;
}

I am aware that there's probably a million things in my code here that can be done better and I gladly listen if you have any suggestions, but the thing I wish to ask is:

How can I get all the values from each class using maybe just one name? Ex. Instead doing as I do now, is there a way so I can do something similar to this:

case 1: 
    setValues(Lvl01.Values); 
    break;

The problem here is in the setValues method, some of the levels has quite a lot of settings that I wish to use, but I doubt the method would want to take like 15 parameters, and I'm not sure what to do when some levels are not using settings that other levels use.

How should I change my code so I do not have to use every single value as a parameter?

Upvotes: 2

Views: 3128

Answers (2)

Eric J.
Eric J.

Reputation: 150108

You could use a Dictionary<int, Level> to lookup the object representing each level. Instead of the switch/case, you would do something like

Level level = myLevelDictionary[currentLevel];

That requires you change your classes from having one class per level, to one class that represents any level, e.g.:

class Level
{
    public int Boxes { get; set; }
    public int MaxPoints { get; set; }
    public int Health { get; set; }
    public int[,] SolidBoxes()
    {
        int[,] position = new int[boardSize, boardSize];
        position[1, 1] = 1;
        return position;
    }
}

You would then populate your dictionary like

Dictionary<int, Level> myLevelDictionary = new Dictionary<int, Level>()
{
    { 1, new Level() { Boxes = 3, MaxPoints = 46, Health = 63 } },
    // etc.
};

UPDATE

A note about abstract classes

You mention abstract classes in your comments. They are useful if all of your levels have some behavior in common, but some have specialized behavior too. They will often be used in games for things that can move in the game, e.g. something like

abstract class Character
{
    // Something everyone has
    public int HitPoints { get; set; }
    // Something everyone does, but does differently
    public abstract void Attack(Character target);    
}

public class Fighter : Character
{
    public int SwordDamage { get; set; }

    public void Attack(Character target)
    {
        target.Damage(this.SwordDamage - target.PhysicalDamageResistance);
    }
}

public class Mage : Character
{
    public int MagicFireDamage { get; set; }
    public int MagicColdDamage { get; set; }

    public void Attack(Character target)
    {
        if (UseFireDamage()) // e.g. roll random chance that the mage uses a fire spell
        {
            target.Damage(this.SwordDamage - target.FireDamageResistance);
        }
        else
        {
            target.Damage(this.SwordDamage - target.ColdDamageResistance);
        }

    }
}

Upvotes: 3

RadioSpace
RadioSpace

Reputation: 952

one way maybe to use a dictionary.

class Level01
{
Dictionary<string,int> values;

public level01()
{
   values.Add("Boxes",3);
   values.Add("MaxPoints",3);
   values.Add("Health",3);

}
 //indexer
public int this[string s] {get{return values[s];} set {values[s] = value;}}

}

and use like:

Level01 lv = new Level01();
somemethod(lv["Boxes"]); //passes 3 to some method

although really you would want to use Dictionary<string,object> and add some type checking and other things to make it work smoothly but hopefully you can get started with that

Upvotes: 1

Related Questions