CODEWITHSUNDEEP
javascriptinternet-explorernumbersisinteger
huangxbd1990
huangxbd1990

Reputation: 239

Number.isInteger(x) which is created can not work in IE

Number.prototype.isInteger = Number.prototype.isInteger || function(x) {
  return (x ^ 0) === x;
}
console.log(Number.isInteger(1));

will throw error in IE10 browser

Upvotes: 8

Views: 12139

Answers (3)

Arunprasanth K V
Arunprasanth K V

Reputation: 21931

Create a polyfill Number.isInteger

Number.isInteger = Number.isInteger || function(value) {
    return typeof value === "number" &&
           isFinite(value) &&
           Math.floor(value) === value;
};

This should solve the issue related to IE.

Upvotes: 1

Alnitak
Alnitak

Reputation: 339816

Notwithstanding possible issues with adding to native prototypes in MSIE, your function body is inappropriate for a method added to Number.prototype.

Methods on the prototype are called on instances of the type, and the instance is passed as this (and will always be an object, not a primitive).

Therefore a more correct implementation would be:

Number.prototype.isInteger = function() {
  return (this ^ 0) === +this;
}

with usage:

(1).isInteger();

If you wanted to use Number.isInteger(n) instead, you would have had to add your function directly to the Number object, not its prototype. There's a rigorous shim for this on the MDN page for this function.

Upvotes: 2

Muhammad Ahsan Ayaz
Muhammad Ahsan Ayaz

Reputation: 1947

Apparently, IE treats DOM objects and Javascript objects separately, and you can't extend the DOM objects using Object.prototype.

IE doesn't let you use a prototype that is not native..

You'll have to make a separate function (global if you want) as

function isInteger(num) {
  return (num ^ 0) === num;
}

console.log(isInteger(1));

Upvotes: 10

Related Questions