CODEWITHSUNDEEP
clojureplumatic-schema
tangrammer
tangrammer

Reputation: 3061

Using clojure.core/Extend with Prismatic schema I get different behavior of s/protocol in s/validate and in s/with-fn-validation

I'm trying to validate the protocol of an instance of defrecord that I generate dynamically using clojure.core/extend

Below You can see that satisfies returns true and (s/validate (s/protocol ...)) doesn't throw exception, but if I run s/with-fn-validation I get a "(not (satisfies? protocol ..... " schema exception although inside this body I keep getting the same true result for (satisfies? protocol x)

(ns wrapper.issue
  (:require [schema.core :as s]))

(defprotocol Welcome
  (greetings [e] )
  (say_bye [e a b])
  )

(s/defn greetings+ :-  s/Str
  [component :- (s/protocol Welcome)]
  (greetings component))

(defrecord Example []
  Welcome
  (greetings [this] "my example greeting!")
  (say_bye [this a b] (str "saying good bye from " a " to " b))
  )

(defrecord MoreSimpleWrapper [e])

(extend MoreSimpleWrapper
  Welcome
  {:greetings (fn [this]
      (str "wrapping!! " (greetings (:e this)))
      )
   :say_bye (fn  [this a b]
               (str "good bye !"))})


(println (satisfies? Welcome (MoreSimpleWrapper. (Example.))))
;;=>true
(println  (s/validate (s/protocol Welcome) (MoreSimpleWrapper. (Example.))))
;;=>#wrapper.issue.MoreSimpleWrapper{:e #wrapper.issue.Example{}}

(s/with-fn-validation
  (println (satisfies? Welcome (MoreSimpleWrapper. (Example.))))
  ;;=>true
  (println  (s/validate (s/protocol Welcome) (MoreSimpleWrapper. (Example.))))
  ;;=>#wrapper.issue.MoreSimpleWrapper{:e #wrapper.issue.Example{}}
)

(s/with-fn-validation
  (greetings+ (MoreSimpleWrapper. (Example.))))
;;=>CompilerException clojure.lang.ExceptionInfo: Input to greetings+ does not match schema: [(named (not (satisfies? Welcome a-wrapper.issue.MoreSimpleWrapper)) component)] {:schema [#schema.core.One{:schema (protocol Welcome), :optional? false, :name component}], :value [#wrapper.issue.MoreSimpleWrapper{:e #wrapper.issue.Example{}}], :error [(named (not (satisfies? Welcome a-wrapper.issue.MoreSimpleWrapper)) component)]}, compiling:(/Users/tangrammer/git/olney/wrapper/src/wrapper/issue.clj:39:69)

Here also a gist with the code

Upvotes: 0

Views: 362

Answers (1)

tangrammer
tangrammer

Reputation: 3061

It was a schema bug :)

now fixed in snapshot-0.3.2

https://github.com/Prismatic/schema/issues/164

Upvotes: 0

Related Questions