CODEWITHSUNDEEP
django
yayu
yayu

Reputation: 8088

Django: Integrity error UNIQUE constraint failed: user_profile.user_id

When I am trying to edit a profile to add info to a UserProfile model, I am getting this strange error:

IntegrityError at /profiles/edit/
UNIQUE constraint failed: user_profile.user_id

What is wrong here,

model:

class UserProfile(models.Model):

    user = models.OneToOneField(User)
    bio = models.TextField(blank=True)
    phone= models.CharField(max_length=10, blank=True)
    address = models.CharField(max_length=1024)
    age = models.PositiveIntegerField(blank=True,null=True)
    gender = models.IntegerField(choices=GENDER_CHOICES, default=1)

form:

class UserProfileForm(forms.ModelForm):

    class Meta:
        model = UserProfile
        fields = ('phone','age','gender','address','bio')

view:

def edit_profile(request):

    if request.method == 'POST':
        form = UserProfileForm(request.POST)
        print request.POST
        if form.is_valid():

            new_profile = UserProfile(
                            user = request.user,
                            bio = request.POST['bio'],
                            address = request.POST['address'],
                            age = request.POST['age']
                            )

            new_profile.save()

            return HttpResponseRedirect(reverse('user_public_profile', args=(request.user.username,)))
        return render(request,'users/edit_profile.html', {'form': form})

    else:
        form = UserProfileForm()
        return render(request,'users/edit_profile.html',
                          {'form': form})

Upvotes: 25

Views: 71012

Answers (6)

Shubham Gupta - TCH
Shubham Gupta - TCH

Reputation: 145

I was getting the same error multiple times and I was really disheartened but finally came over the solution.

Convert:

user = models.OneToOneField(User)

to

user = models.ForeignKey(User)

This should solve the issue.

Upvotes: 9

localhost_3000
localhost_3000

Reputation: 196

Consider the case: If the same user makes the post request again on URL 'profile/edit' then your code will try to create the new UserProfile using the same user instance, but since this is a one to one field and you have already created one profile using that user hence it will throw integrity error.

So you should check first if the profile associated with that user already exists or not, then if it didn't exist then create it.

Upvotes: 2

Carcigenicate
Carcigenicate

Reputation: 45726

I accidentally got this error because I forgot to specify update_fields in my call to save. I had:

modified_instance.save(video_attr)

When I should have had:

modified_instance.save(update_fields=[video_attr])

The truthy string was being interpreted as the positional force_update parameter, which obviously causes problems if the record already exists.

Upvotes: 0

0536
0536

Reputation: 9

add (instance = request.user) in UserProfileForm(request.POST)

Upvotes: 0

vipin yadav
vipin yadav

Reputation: 68

Yes you are making a OneToOne relation between User and UserProfile models that's why you are facing integrity error, for fixing this you can change it to ForeignKey Like :

class UserProfile(models.Model):

user = models.ForeignKey(User,on_delete=models.CASCADE)
bio = models.TextField(blank=True)
...
...

Upvotes: -2

Daniel Roseman
Daniel Roseman

Reputation: 599450

It's not strange. You already have a profile for that user, so adding another one breaks the unique constraint. You need to edit the existing one, not add a new one.

Also note that you're not using the cleaned form data when you save, which you should be. Either use form.cleaned_data['bio'] etc, or even better just do form.save() which is the whole point of using a model form.

Putting that together:

try:
    profile = request.user.userprofile
except UserProfile.DoesNotExist:
    profile = UserProfile(user=request.user)

if request.method == 'POST':
    form = UserProfileForm(request.POST, instance=profile)
    if form.is_valid():
        form.save()
        return redirect...
else:
    form = UserProfileForm(instance=profile)
return render...

Upvotes: 31

Related Questions