CODEWITHSUNDEEP
c++macrosc-preprocessor
Nathan Osman
Nathan Osman

Reputation: 73195

Why won't this compile and how can it be implemented so that it does?

Here is some C++ code I'm playing around with:

#include <iostream>
#include <vector>

#define IN ,
#define FOREACH(x,y) for(unsigned int i=0;i<y.size();i++) { x=y[i];
#define ENDFOREACH }

using namespace std;

int main()
{
    vector<int> ints;
    ints.push_back(3);
    ints.push_back(4);
    ints.push_back(5);
    ints.push_back(6);

    FOREACH(int item IN ints)
        cout << item;
    ENDFOREACH

    return 0;
}

However, I get an error:

macro "FOREACH" requires 2 arguments, but only 1 given

The code compiles if I change the IN to a comma. How can I get the IN to take the place of a comma?

Update: for those interested, here is the final version, which, if I do say so myself, is quite nice.

#include <iostream>
#include <vector>

#define in ,
#define as ,
#define FOREACH_(x,y,z) \
        y x; \
        if(z.size()) x = z[0]; \
        for(unsigned int i=0,item;i<z.size();i++,x=z[i])
#define foreach(x) FOREACH_(x)

using namespace std;

int main()
{
    vector<int> ints;
    ints.push_back(3);
    ints.push_back(4);
    ints.push_back(5);
    ints.push_back(6);

    foreach(item as int in ints)
    {
        cout << item << endl;
    }

    return 0;
}

Upvotes: 2

Views: 260

Answers (6)

Chris Dodd
Chris Dodd

Reputation: 126203

#define IN ,
#define XFOREACH(x,y) for(unsigned int i=0;i<y.size();i++) { x=y[i];
#define FOREACH(x) XFOREACH(x)
#define ENDFOREACH }

As previous posters have noted, the preprocessor does not expand macros in the arglist before it splits it into argument. However, as long as the macro doesn't use # or ##, it expands macros in the args before substituting them into the macro body, so an extra indirection does the trick

Upvotes: 1

AnT stands with Russia
AnT stands with Russia

Reputation: 320481

Others have already explained why it doesn't compile as is.

In order to make it work you have to give that IN a chance to turn into a comma. For that you can introduce an extra level of "indirection" in your macro definition

#define IN , 
#define FOREACH_(x,y) for(unsigned int i=0;i<y.size();i++) { x=y[i]; 
#define FOREACH(x) FOREACH_(x)
#define ENDFOREACH }

In this case you'll have to use some substitute for comma (like your IN) and can no longer specify comma explicitly. I.e. now this

FOREACH(int item IN ints) 
    cout << item; 
ENDFOREACH

compiles fine, while 

FOREACH(int item, ints) 
    cout << item; 
ENDFOREACH

does not.

Upvotes: 4

Georg Fritzsche
Georg Fritzsche

Reputation: 98984

Expansion for IN doesn't happen early enough in your example, but you can pass the expanded version to another macro:

#define FOREACH(x) DO_FOREACH(x)
#define DO_FOREACH(x,y) for( ... ) ...

Upvotes: 1

zmbush
zmbush

Reputation: 2810

The preprocessor doesn't expand the IN to a comma until after it reads the arguments to FOREACH.

I'm pretty sure that the c++ preprocessor is one pass only, so you'll have to use: 

FOREACH(int item, ints)
    cout << item;
ENDFOREACH

Upvotes: 0

George Godik
George Godik

Reputation: 1716

Check out BOOST_FOREACH - it does what you want

http://www.boost.org/doc/libs/1_35_0/doc/html/foreach.html

Upvotes: 0

Zifre
Zifre

Reputation: 26998

The compiler doesn't expand the IN macro before it reads the arguments to FOREACH. In fact, I think this is intentional (so that you can pass a comma to a macro).

Unfortunately, you'll have to use FOREACH(int item, ints).

You could also #define IN (make it nothing) and then use FOREACH(int item, IN ints), which is not quite as nice, but is acceptable.

That said, you may just want to use STL or Boost for foreach, unless you specifically want to create your own.

Upvotes: 3

Related Questions