CODEWITHSUNDEEP
javanumber-formattingdecimalformat
George
George

Reputation: 8378

DecimalFormat and Double.valueOf()

I'm trying to get rid of unnecessary symbols after decimal seperator of my double value. I'm doing it this way:

DecimalFormat format = new DecimalFormat("#.#####");
value = Double.valueOf(format.format(41251.50000000012343));

But when I run this code, it throws:

java.lang.NumberFormatException: For input string: "41251,5"
    at sun.misc.FloatingDecimal.readJavaFormatString(FloatingDecimal.java:1224)
    at java.lang.Double.valueOf(Double.java:447)
    at ...

As I see, Double.valueOf() works great with strings like "11.1", but it chokes on strings like "11,1". How do I work around this? Is there a more elegant way then something like

Double.valueOf(format.format(41251.50000000012343).replaceAll(",", "."));

Is there a way to override the default decimal separator value of DecimalFormat class? Any other thoughts?

Upvotes: 20

Views: 71045

Answers (10)

Tobias Kienzler
Tobias Kienzler

Reputation: 27415

By

get rid of unnecessary symbols after decimal seperator of my double value

do you actually mean you want to round to e.g. the 5th decimal? Then just use

value = Math.round(value*1e5)/1e5;

(of course you can also Math.floor(value*1e5)/1e5 if you really want the other digits cut off)

edit

Be very careful when using this method (or any rounding of floating points). It fails for something as simple as 265.335. The intermediate result of 265.335 * 100 (precision of 2 digits) is 26533.499999999996. This means it gets rounded down to 265.33. There simply are inherent problems when converting from floating point numbers to real decimal numbers. See EJP's answer here at https://stackoverflow.com/a/12684082/144578 - How to round a number to n decimal places in Java

Upvotes: 91

Tobias Kienzler
Tobias Kienzler

Reputation: 27415

Use Locale.getDefault() to get your system's decimal separator which you can also set. You can't have two different separators at the same time since the other is then usually used as the separator for thousands: 2.001.000,23 <=> 2,001,000.23

Upvotes: 6

Neoray
Neoray

Reputation: 19

My code function :

 private static double arrondi(double number){
         DecimalFormatSymbols symbols = DecimalFormatSymbols.getInstance();
         symbols.setDecimalSeparator('.');
         DecimalFormat format = new DecimalFormat("#.#####", symbols);
         return Double.valueOf(format.format(number));
     }

Upvotes: -1

PaulMurrayCbr
PaulMurrayCbr

Reputation: 1260

The real solution is: don't use floating-point numbers for anything that needs to be counted with precision:

  • If you are dealing with currency, don't use a double number of dollars, use an integer number of cents.
  • If you are dealing with hours of time and need to count quarter-hours and 10-minute intervals, use an integer number of minutes.

A floating point number is almost always an approximation of some real value. They are suitable for measurements and calculation of physical quantities (top a degree of precision) and for statistical artifacts.

Fooling about with rounding floating point to a number of digits is a code smell: it's wasteful and you can never really be sure that your code will work properly in all cases.

Upvotes: 10

Vaibhav Barad
Vaibhav Barad

Reputation: 625

looks like your local use a comma "," as a decimal separation.To get the "." as a decimal separator, you will have to declare:

DecimalFormat dFormat =new DecimalFormat("#.#", new DecimalFormatSymbols(Locale.ENGLISH));

Upvotes: 4

Maxime ARNSTAMM
Maxime ARNSTAMM

Reputation: 5314

For the ',' instead of the '.' , you'd have to change the locale.

For the number of decimals, use setMaximumFractionDigits(int newValue).

For the rest, see the javadoc.

Upvotes: 3

Chris Dail
Chris Dail

Reputation: 26059

The problem is that your decimal format converts your value to a localized string. I'm guessing that your default decimal separator for your locale is with a ','. This often happens with French locales or other parts of the world.

Basically what you need to do is create your formatted date with the '.' separator so Double.valueOf can read it. As indicated by the comments, you can use the same format to parse the value as well instead of using Double.valueOf.

DecimalFormatSymbols symbols = DecimalFormatSymbols.getInstance();
symbols.setDecimalSeparator('.');
DecimalFormat format = new DecimalFormat("#.#####", symbols);
value = format.parse(format.format(41251.50000000012343));

Upvotes: 22

Joao Coelho
Joao Coelho

Reputation: 3166

Somewhat related to this, but not an answer to the question: try switching to BigDecimal instead of doubles and floats. I was having a lot of issue with comparisons on those types and now I'm good to go with BigDecimal.

Upvotes: 2

BalusC
BalusC

Reputation: 1109665

You can't change the internal representation of double/Double that way.

If you want to change the (human) representation, just keep it String. Thus, leave that Double#valueOf() away and use the String outcome of DecimalFormat#format() in your presentation. If you ever want to do calculations with it, you can always convert back to a real Double using DecimalFormat and Double#valueOf().

By the way, as per your complain I'm trying to get rid of unnecessary symbols after decimal seperator of my double value, are you aware of the internals of floating point numbers? It smells a bit like that you're using unformatted doubles in the presentation layer and that you didn't realize that with the average UI you can just present them using DecimalFormat without the need to convert back to Double.

Upvotes: 2

matt b
matt b

Reputation: 140061

The fact that your formatting string uses . as the decimal separator while the exception complains of , points to a Locale issue; i.e. DecimalFormat is using a different Locale to format the number than Double.valueOf expects.

In general, you should construct a NumberFormat based on a specific Locale. 

Locale myLocale = ...;
NumberFormat f = NumberFormat.getInstance(myLocale);

From the JavaDocs of DecimalFormat:

To obtain a NumberFormat for a specific locale, including the default locale, call one of NumberFormat's factory methods, such as getInstance(). In general, do not call the DecimalFormat constructors directly, since the NumberFormat factory methods may return subclasses other than DecimalFormat.

However as BalusC points out, attempting to format a double as a String and then parse the String back to the double is a pretty bad code smell. I would suspect that you are dealing with issues where you expect a fixed-precision decimal number (such as a monetary amount) but are running into issues because double is a floating point number, which means that many values (such as 0.1) cannot be expressed precisely as a double/float. If this is the case, the correct way to handle a fixed-precision decimal number is to use a BigDecimal.

Upvotes: 7

Related Questions