CODEWITHSUNDEEP
javascriptjqueryvariablestogglesimplify
Owly
Owly

Reputation: 575

How to simplify jquery code with variables?

I have this jQuery code I've done to toggle floating sections with image previews. The layer is always the same, only the images change. I've manage to simplify the code in css giving classes to the elements. Everything works fine. However I'm finding it very hard to optimize the jQuery code. I'm pretty new to jQuery and Javascript so I'm not quite sure how to do this. The code works fine but It's massive huge and I want to simplify it. I believe I have to use variables. But how? Any help would be appreciated :)

this is my jQuery code:

//first layer

$(document).ready(function() {
$('.toggleLayer').click(function(){
$('#FloatingLayer').fadeIn('fast');
});
});

$(document).ready(function() {
$('#FloatingLayer').click(function(){
$(this).fadeOut('fast');
});
});


//second layer

$(document).ready(function() {
$('.toggleLayer2').click(function(){
$('#FloatingLayer2').fadeIn('fast');
});
});

$(document).ready(function() {
$('#FloatingLayer2').click(function(){
$(this).fadeOut('fast');
});
});



// third layer

$(document).ready(function() {
$('.toggleLayer3').click(function(){
$('#FloatingLayer3').fadeIn('fast');
});
});

$(document).ready(function() {
$('#FloatingLayer3').click(function(){
$(this).fadeOut('fast');
});
});

And here is my html:

<div class="fourcol toggleLayer">   
     <img src="img1" class="center" width="100%">
  </div>

  <div class="fourcol toggleLayer2">   
     <img src="img2.jpg" class="center" width="100%">
  </div>

  <div class="fourcol toggleLayer3">   
     <img src="img3" class="center" width="100%" >
  </div>

the floating sections: 

<section class="Floating" id="FloatingLayer">
     <img src="img1.jpg" class="floatimg"/>
   </section>

   <section class="Floating" id="FloatingLayer2">
     <img src="img2.jpg" class="floatimg"/>
   </section>

  <section class="Floating" id="FloatingLayer3">
     <img src="img3.jpg" class="floatimg"/>
   </section>

Upvotes: 0

Views: 437

Answers (2)

Pointy
Pointy

Reputation: 413856

Take advantage of the fact that you can add information to your markup that guides behaviors supplied by your JavaScript code. Assuming your toggle controls are buttons:

<button class=toggle-layer data-target=FloatingLayer1>Layer 1</button>
<button class=toggle-layer data-target=FloatingLayer2>Layer 2</button>
<button class=toggle-layer data-target=FloatingLayer3>Layer 3</button>

edit — or with your actual markup:

  <div class="fourcol toggleLayer" data-target=FloatingLayer1>   
     <img src="img1" class="center" width="100%">
  </div>

  <div class="fourcol toggleLayer" data-target=FloatingLayer2>   
     <img src="img2.jpg" class="center" width="100%">
  </div>

  <div class="fourcol toggleLayer" data-target=FloatingLayer3>   
     <img src="img3" class="center" width="100%" >
  </div>

You now can write one simple handler for all of them:

$("body").on("click", ".toggleLayer", function() {
  var targetId = $(this).data("target");

  $("#" + targetId).fadeIn("fast");
});

Similarly, one handler can do the work to close all the layers:

$("body").on("click", ".Floating", function() {
    $(this).fadeOut("fast");
});

If you use event delegation as in these examples, you don't have to put the code in a "ready" handler.

Upvotes: 1

plalx
plalx

Reputation: 43728

Without changing your markup at all...

var $body = $(document.body);

$body.on('click', '[class~=toggleLayer]', function () {
    var layerNum = this.className.match(/toggleLayer(\d+)/)[1];

    $('#FloatingLayer' + layerNum).fadeIn('fast');
});

$body.on('click', '.Floating', function () {
    $(this).fadeOut('fast');
});

However, the behavior is not explicit here and it would be better to modify your markup and use custom data- attributes like suggested by Pointy.

Upvotes: 2

Related Questions