CODEWITHSUNDEEP
djangodjango-models
Giovanni Di Milia
Giovanni Di Milia

Reputation: 14041

Django: Only one of two fields can be filled in

I have this model:

class Journals(models.Model):
    jid = models.AutoField(primary_key=True)
    code = models.CharField("Code", max_length=50)
    name = models.CharField("Name", max_length=2000)
    publisher = models.CharField("Publisher", max_length=2000)
    price_euro = models.CharField("Euro", max_length=2000)
    price_dollars = models.CharField("Dollars", max_length=2000)

Is there a way to let people fill out either price_euro or price_dollars?

I do know that the best way to solve the problem is to have only one field and another table that specify the currency, but I have constraints and I cannot modify the DB.

Thanks!

Upvotes: 13

Views: 6788

Answers (4)

jnns
jnns

Reputation: 5634

Since Django 2.2 database constraints can be used. That means, that on top of the regular model-level validation (which has worked since forever and has been suggested by Tom) you can now make sure that invalid data cannot enter the database at all.

# models.py 
from django.db import models
from django.db.models import Q

class Journals(models.Model):
    # [...]
    
    def clean(self):
        """Ensure that only one of `price_euro` and `price_dollars` can be set."""
        if self.price_euro and self.price_dollars:
            raise ValidationError("Only one price field can be set.")


    class Meta:
        constraints = [
            models.CheckConstraint(
                check=(
                    Q(price_euro__isnull=False) & 
                    Q(price_dollars__isnull=True)
                ) | (
                    Q(price_euro__isnull=True) & 
                    Q(price_dollars__isnull=False)
                ),
                name='only_one_price',
            )
        ]

Make sure to create and apply a migration after Meta.constraints has been changed. Documentation on Meta.constraints is available here.

Upvotes: 14

wobbily_col
wobbily_col

Reputation: 11901

I would do it on the model clean() method. That way it will work with the Admin site as well.

https://docs.djangoproject.com/en/dev/ref/models/instances/#django.db.models.Model.clean

Upvotes: 1

Tom
Tom

Reputation: 22841

I'd agree with T. Stone that customizing the form is the best way to go. If you can't do that, or in addition to that, you can enforce the rule with a custom clean() method on your form. Just bear in mind that any validation errors you throw in the clean() method won't be attached to specific fields, but to the form itself.

Upvotes: 4

T. Stone
T. Stone

Reputation: 19495

It's not necessary that the interface reflects the data structure. You could simply have your UI present them with 1 currency field and then a selection between USD and Euro, then when the data is committed back to the Journals model, you simply assign it to the correct field and clear the other.

Upvotes: 7

Related Questions