CODEWITHSUNDEEP
javaarrays
connor moore
connor moore

Reputation: 611

Array index out of bounds - 2d to 1d

I am working with the algs4 8-puzzle program presented by Princeton. I am getting an array index out of bounds exception in my second for loop. Does anyone see the issue that is throwing this exception? My board class + relevant method looks like this:

public class Board {
 private final int[][] blocks;
 private final int N;

 // construct a board from an N-by-N array of blocks
 // (where blocks[i][j] = block in row i, column j)
    public Board(int[][] blocks){
     N = blocks.length;
     this.blocks = new int[N][];
     for (int i=0; i<N; i++){
      this.blocks[i] = Arrays.copyOf(blocks[i], N);
     }
    }

    // board dimension N
    public int dimension(){
     return this.N;
    }

   //is the board solvable? 
   public boolean isSolvable(){
      int inversions = 0; 
      List<Integer> convert = new ArrayList<>(); // convert 2d to 1d 
      for (int i = 0; i < blocks.length; i++){
          for (int j = 0; j < blocks[i].length; j++){
              convert.add(blocks[i][j]);
          }
      }
      for (int i = 0; i < blocks.length; i++){ //counts the number of inversions 
          if (convert.get(i) < convert.get(i-1)){ //ARRAYINDEXOUTOFBOUNDS -1
              inversions++; 
          }
      }
      if (inversions % 2 == 0){
          return true; //even 
      }
      return false; //odd 
  }

Upvotes: 0

Views: 85

Answers (1)

Eran
Eran

Reputation: 393841

convert.get(i-1) is out of bounds when i==0.

You should probably change the start index of your loop :

  for (int i = 1; i < blocks.length; i++){ //counts the number of inversions 
      if (convert.get(i) < convert.get(i-1)){ 
          inversions++; 
      }
  }

Upvotes: 1

Related Questions