CODEWITHSUNDEEP
c++design-patterns
oh boy
oh boy

Reputation: 545

C++ OOP: Which functions to put into the class?

Assume I have a class a:

class a
{
public:
  void load_data( );
private:
  void check_data( );
  void work_data( );
  void analyze_data( );
}

Those functions all do something with the class or one of its members.

However this function:

bool validate_something( myType myData )
{
     if ( myData.blah > 0 && myData.blah < 100 )
     {
        return true;
     }
     return false;
}

Where to put validate_something? Inside or outside the class?

Upvotes: 6

Views: 600

Answers (5)

Adam Bowen
Adam Bowen

Reputation: 11230

If a function is

  • not required outside of the class, and,
  • doesn't need to access class members (or perhaps makes sense as a free function with members as parameters)

then I tend to make it a free function inside a private namespace in the implementation file. I prefer not to use private functions because they expose implementation detail in the header file (and haven't yet encountered Neil's problems) and I prefer to avoid recompiling for implementation changes.

Upvotes: 11

Maciej Hehl
Maciej Hehl

Reputation: 7985

As I understand, it's not a method. Just put it's definition in the cpp file, above the definitions of the methods that use it. If You have all your method definitions inline in Your class You have to put the prototype of the function in the header above the class definition, but the definition can still be in a cpp file.

Upvotes: 0

Patrick
Patrick

Reputation: 23619

Assuming that myType is also a struct/class, why don't you make validate_something a method of myType?

Upvotes: 0

anon
anon

Reputation:

Make it a private static class member. I used to tend to make these non-class members and put them in an nameless namespace in the implementation file, but it seems that they almost always do end up needing to be class members (or need to be moved elsewhere - perhaps to a validation library, in your example), as the code changes, so now I almost always make them static members.

Please notice the use of "almost" as a qualifier throughout this answer :-)

Upvotes: 5

Reed Copsey
Reed Copsey

Reputation: 564333

If this method is a utility that's only being used by the class, I would make it a private method of the class. This way, it's encapsulated and not "polluting" your public API.

Upvotes: 0

Related Questions