CODEWITHSUNDEEP
angularjsasynchronous
anazimok
anazimok

Reputation: 1759

Angularjs 1.3 async filter not working

I have following code, which basically loads messages from the server via $http.get request in the service and then used in the i18n filter. Filter was working fine with angular version 1.2.24 but after updating to 1.3.5 it no longer works.

I was wondering if anyone ran into similar issue and can shine some light on this.

var module = angular.module('myApp', [])

.factory('MessageFactory', function ($http, $locale, $log) {
    var messages = {};

    $http.get("/i18n/" + $locale.id + "/list", {cache: true}).success(function(data) {
        $log.debug("Getting messages for", $locale.id);
        messages = data;
    });

    return {
        getMessage: function (key) {
            return messages[key];
        }
    }
})

.filter('i18n', function (MessageFactory) {
    return function (key) {
        return MessageFactory.getMessage(key);
    }
});

Html Code

<h2>{{'message.page.title'|i18n}}</h2>

Upvotes: 5

Views: 1698

Answers (2)

anazimok
anazimok

Reputation: 1759

Finally after couple of hours of digging I changed 

.filter('i18n', function (MessageFactory) {
    return function (key) {
        return MessageFactory.getMessage(key);
    }
});

to

.filter('i18n', function (MessageFactory) {
    function filterFn(key) {
        return MessageFactory.getMessage(key);
    }

    filterFn.$stateful = true;

    return filterFn;
});

Notice filterFn.$stateful that's what did the trick.

Upvotes: 10

Rasalom
Rasalom

Reputation: 3111

I couldn't find docs proof of that, but it looks like angular 1.3.x executes code inside modules only when it firstly used, and <= 1.2.x do it when app started.

Looks like you need to change your code to load locale files in app.run() method;

Something like this: http://codepen.io/anon/pen/vELogx

Upvotes: 0

Related Questions