Peter Stewart
Peter Stewart

Reputation: 3017

I'm having trouble with using std::stack to retrieve the values from a recursive function

Thanks to the help I received in this post:

How do I use "this" in a member function?

I have a nice, concise recursive function to traverse a tree in postfix order:

void Node::postfix()
{
        if (left != __nullptr) { left->postfix(); } 
        if (right != __nullptr) { right->postfix(); } 
                cout<<cargo<<"\n"; 
        return;
};

Now I need to evaluate the values and operators as they are returned. My problem is how to retrieve

them. I tried the std::stack:

#include <stack> 
stack <char*> s;
void Node::postfix()
{
        if (left != __nullptr) { left->postfix(); } 
        if (right != __nullptr) { right->postfix(); } 
        s.push(cargo);
        return;
};

but when I tried to access it in main()

while (!s.empty())
{
    cout<<s.top<<"\n";
    s.pop;
}

I got the error:

'std::stack<_Ty>::top': function call missing argument list; use '&std::stack<_Ty>::top' to create

a pointer to member'

I'm stuck.

Another question to follow shortly.

Upvotes: 2

Views: 291

Answers (3)

James McNellis
James McNellis

Reputation: 355167

They are member functions:

s.top()
s.pop()
     ^ need parentheses to call a function

That's what the error means when it says "function call missing argument list." The argument list (which in this case is empty since the function takes no parameters) and the parentheses are missing.

Upvotes: 9

Naveen
Naveen

Reputation: 73463

top() is a member function in std::stack not a member variable. So you need the parenthesis while calling top

Upvotes: 1

Niki Yoshiuchi
Niki Yoshiuchi

Reputation: 17581

top and pop are functions, not member variables. You should write

s.top();
s.pop();

Upvotes: 1

Related Questions