CODEWITHSUNDEEP
c#wpfxamlmvvm
Tobias Johansson
Tobias Johansson

Reputation: 70

WPF: set property does not trigger on textbox value changed

I have a EditUserViewModel which binds a User model. In the User model I have public properties such as Firstname, Lastname, Age, etc.

EditUserViewModel

public class EditUserViewModel : BindableBase
{
    private User _user;

    public EditUserViewModel(User user)
    {
        SaveCommand = new DelegateCommand(EditUser, CanSaveCommand);
        CancelCommand = new DelegateCommand(Cancel);
        User = user;
    }

    public User User
    {
        get{ return _user; }
        set
        {
            _user = value;
            OnPropertyChanged(() => User);
            SaveCommand.RaiseCanExecuteChanged();
        }
    }

    public DelegateCommand SaveCommand { get; set; }
    public ICommand CancelCommand { get; set; }

    public Func<bool> CanSaveCommand { get { return CanEditUser; } }

    private void EditUser()
    {
        Confirmed = true;
        FinishInteraction();
    }

    private bool CanEditUser()
    {
        if (string.IsNullOrEmpty(_user.Firstname) || _user.Firstname.Length < 3) return false;
        if (string.IsNullOrEmpty(_user.Lastname) || _user.Lastname.Length < 3) return false;

        return true;
    }
}

EditUserView

<UserControl x:Class="UserModule.Views.EditUserView"
             xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
             xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
             xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006" 
             xmlns:d="http://schemas.microsoft.com/expression/blend/2008" 
             mc:Ignorable="d" 
             d:DesignHeight="300" d:DesignWidth="300">
    <Grid>

        <Grid.RowDefinitions>
            <RowDefinition/>
            <RowDefinition/>
            <RowDefinition/>
        </Grid.RowDefinitions>

        <Grid.ColumnDefinitions>
            <ColumnDefinition/>
            <ColumnDefinition/>
        </Grid.ColumnDefinitions>

        <TextBlock FontWeight="Bold" Grid.Row="0" Grid.Column="0">First name:</TextBlock>
        <TextBox Grid.Row="0" Grid.Column="1" Text="{Binding Path=User.Firstname, Mode=TwoWay, UpdateSourceTrigger=PropertyChanged}"/>

        <TextBlock FontWeight="Bold" Grid.Row="1" Grid.Column="0">First name:</TextBlock>
        <TextBox Grid.Row="1" Grid.Column="1" Text="{Binding Path=User.Lastname, Mode=TwoWay, UpdateSourceTrigger=PropertyChanged}"/>

        <Button x:Name="OkButton" Grid.Row="2" Grid.Column="0" Command="{Binding SaveCommand}" Content="OK"/>
        <Button x:Name="CancelButton" Grid.Row="2" Grid.Column="1" Command="{Binding CancelCommand}" Content="Cancel"/>
    </Grid>

</UserControl>

User

public User 
{
    public string Firstname  { get; set; }
    public string Lastname  { get; set; }
    public string Age  { get; set; }
}

However, when I change the firstname or the lastname, the User property does not trigger its setter. But if I, instead of using a User class property, have Firstname and Lastname string properties in the Viewmodel, their setters gets triggered when I change their values in the GUI. Do I need to do anything specific to make this class property binding work?

Upvotes: 0

Views: 2710

Answers (3)

Vimal CK
Vimal CK

Reputation: 3563

    public class User : BindableBase
    {
       private string _firstName;
       private string _lastName;
       private string _age;

    public string Firstname  
    { 
      get{ return _firstName;} 
      set
      {
           _firstName = value;
           OnPropertyChanged(() => Firstname);
      }
    }

    public string LastName
    { 
      get{ return _lastName;} 
      set
      {
           _lastName = value;
           OnPropertyChanged(() => LastName);
      }
    }

    public string Age
    { 
      get{ return _age;} 
      set
      {
           _age = value;
           OnPropertyChanged(() => Age);
      }
    }
}

Upvotes: 1

SamTh3D3v
SamTh3D3v

Reputation: 9944

Make sure the User Class implements The INotifyPropertyChanged

  public class User : INotifyPropertyChanged
{
    private String _firstname;
    public String Firstname
    {
        get
        {
            return _firstname;
        }

        set
        {
            if (_firstname == value)
            {
                return;
            }

            _firstname = value;
            OnPropertyChanged();
        }
    } 
    private String _lastName;
    public String LastName
    {
        get
        {
            return _lastName;
        }

        set
        {
            if (_lastName == value)
            {
                return;
            }

            _lastName = value;
            OnPropertyChanged();
        }
    }
    public ObservableCollection<DataGridEntry> DataGridEntries { get; set; }

    public event PropertyChangedEventHandler PropertyChanged;

    [NotifyPropertyChangedInvocator]
    protected virtual void OnPropertyChanged([CallerMemberName] string propertyName = null)
    {
        PropertyChangedEventHandler handler = PropertyChanged;
        if (handler != null) handler(this, new PropertyChangedEventArgs(propertyName));
    }
}

Upvotes: 2

MxFragz
MxFragz

Reputation: 198

Implementing INotifiyPropertyChanged in the class User itself should allow the binding to happen through the ViewModel.

http://msdn.microsoft.com/fr-fr/library/system.componentmodel.inotifypropertychanged%28v=vs.110%29.aspx

Upvotes: 0

Related Questions