CODEWITHSUNDEEP
phpmysql
Victor
Victor

Reputation: 351

Beginner PHP: I can't insert data into MYSQL database

I'm learning PHP right now and I'm trying to insert data into a MySQL database called "pumpl2" The table is set up like this.

create table product
 ( productid int unsigned not null auto_increment primary key,
   price int(9) not null,
   value int(9) not null,
   description text
 );

I have a form and want to insert the fields from the form in the database. Here is what the php file looks like.

<?php

// create short variable names
$price = $_POST['price'];
$value = $_POST['value'];
$description = $_POST['description'];

if (!$price || !$value || !$description) {
 echo "You have not entered all the required details.<br />"
  ."Please go back and try again.";
 exit;
}

@ $db = new mysqli('localhost', 'pumpl', '********', 'pumpl2');

if (mysqli_connect_errno()) {
 echo "Error: Could not connect to database. Please try again later.";
 exit;
}

$query = "insert into pumpl2 values
 ('".$price."', '".$value."', '".$description."')";
$result = $db->query($query);

if ($result) {
 echo  $db->affected_rows." product inserted into database.";
} else {
 echo "An error has occurred.  The item was not added.";
}

$db->close();

?>

When I submit the form, I get an error message "An error has occurred. The item was not added."

Does anyone know what the problem is? Thank you!

Upvotes: 1

Views: 9789

Answers (7)

Quassnoi
Quassnoi

Reputation: 425633

$query = "insert into pumpl2.product (price, value, description) values('" .
         $db->read_escape_string($price) . "', '".
         $db->read_escape_string($value) . "', '" .
         $db->read_escape_string($description) . "')";
$result = $db->query($query);

And an obligatory XKCD cartoon:

Upvotes: 2

Daniel Vassallo
Daniel Vassallo

Reputation: 344431

You are trying to insert into the table called pumpl2, but the CREATE TABLE statement created a table called product.

In addition, as ZeissS noted, you have to consider the following:

CREATE TABLE product ( 
    productid int unsigned not null auto_increment primary key,
    price int(9) not null,
    value int(9) not null,
    description text
);
Query OK, 0 rows affected (0.09 sec)

INSERT INTO product VALUES (1, 1, 'test');
ERROR 1136 (21S01): Column count doesn't match value count at row 1

To solve that error, you need to explicitly specify the list of the columns:

INSERT INTO product (price, value, description) VALUES (1, 1, 'test');
Query OK, 1 row affected (0.03 sec)

Upvotes: 4

Klaus Byskov Pedersen
Klaus Byskov Pedersen

Reputation: 120997

Your table is called products not pumpl2. Furthermore you should do:

insert into product (price, value, description) values ( ...

Upvotes: 0

enricog
enricog

Reputation: 4273

Your query is wrong, you didn't have the columns specified. Try it with: 

"INSERT INTO pumpl2 (price, value, description) VALUES ('".$price."', '".$value."', '".$description."')"

Besides that, do not use the $_POST values to enter them directly into the database. Search for SQL Injection on this one. Use mysql_real_escape_string on the $_POST data first, or even better use prepared statements.

Upvotes: 1

Bjoern
Bjoern

Reputation: 16304

It could be several reasons.

Try

echo "Errormessage: ".$db->error;

to get more details, why the Insert didn't work.

Upvotes: 0

Michael Borgwardt
Michael Borgwardt

Reputation: 346397

This should give you more information:

echo "An error has occurred: " . $db->error();

Upvotes: 4

ZeissS
ZeissS

Reputation: 12135

You only insert three columns but have four defined in your table. Thus you have to name the columns explicitly:

 INSERT INTO tableName (ColumnA, ColumnB, ColumnC) VALUES ('A', 'B', 'C')

Upvotes: 3

Related Questions