CODEWITHSUNDEEP
javaandroiddatabasesqlite
Jon G
Jon G

Reputation: 1706

Android - Database insert not inserting

I am including a database in my Android application. I am following the guide here:

http://developer.android.com/training/basics/data-storage/databases.html

I have a "DatabaseHelper" class that extends SQLiteOpenHelper as suggested, and I have a Contract that holds the information about the table and implements 'BaseColumns'. Therein, I have a function for inserting a new row into the database:

public static void addUploadInfo(SQLiteOpenHelper dbHelper, UploadInfo info) {
    // Gets the data repository in write mode
    SQLiteDatabase db = dbHelper.getWritableDatabase();

    ContentValues values = info.getContentValues();

    // Insert the new row, returning the primary key value of the new row
    long newRowId;
    newRowId = db.insert(
            UploadInfoTable.TABLE_NAME,
            null,
            values);

    db.close(); // Closing database connection

    info.setDatabaseId(newRowId);
}

I am using the database to store app related meta data about a file. When I create a new file, I run the above function, and a row is successfully added to the database (and the database is created successfully if needed). I can see it using:

public static List<UploadInfo> getUploadInfoList(SQLiteOpenHelper dbHelper) {
    List<UploadInfo> infoList = new ArrayList<>();

    SQLiteDatabase db = dbHelper.getReadableDatabase();
    String allQuery = "SELECT  * FROM " + UploadInfoTable.TABLE_NAME;
    Cursor cursor = db.rawQuery(allQuery, null);

    if (cursor.moveToFirst()) {
        do {
            infoList.add(new UploadInfo(cursor));
        } while (cursor.moveToNext());
    }

    cursor.close();
    db.close();

    return infoList;
}

However, when the app first loads, I insert a few initial entries into the database using:

@Override
public void onResume() {
    super.onResume();
    DatabaseHelper dbHelper = new DatabaseHelper(getActivity());
    for (UploadInfo info: uploadList) {
        UploadInfoTable.addUploadInfo(dbHelper, info);
    }
}

These entries are assigned a new row ID that appears to be the correct value (not -1 indicating an error). There are no errors in the log. However, they are not found when I next run getUploadInfoList.

I have also tried this alternate insert function:

public static void addUploadInfo(SQLiteOpenHelper dbHelper, UploadInfo info) {
    SQLiteDatabase db = dbHelper.getWritableDatabase();

    ContentValues values = info.getContentValues();

    // Insert the new row, returning the primary key value of the new row
    db.beginTransaction();
    long newRowId = -1;
    try {
        newRowId = db.insertOrThrow(
                UploadInfoTable.TABLE_NAME,
                null,
                values);
        db.setTransactionSuccessful();
    } catch (Exception e) {
        e.printStackTrace();
    } finally {
        db.endTransaction();
    }

    db.close(); // Closing database connection

    info.setDatabaseId(newRowId);
}

but I see the same result. In no case is info null. I always log the contents of the ContentValues. I use final variables for column names, so don't think I have an error in column name. This would show up as a row value of -1 anyway, and it doesn't.

Why would one implementation of the code insert successfully and the other not?

Upvotes: 0

Views: 1557

Answers (1)

gknicker
gknicker

Reputation: 5568

I suspect your code in onResume() is not successfully detecting the upgrade. Rather put all your code having to do with the upgrade in onUpgrade() instead of trying to detect an upgrade in onResume(). That should resolve the issue.

Upvotes: 1

Related Questions