CODEWITHSUNDEEP
c#xmlc#-3.0nullreferenceexception
SMUsamaShah
SMUsamaShah

Reputation: 7890

null reference exception in the code

I am getting NullReferenceException error on "_attr.Append(xmlNode.Attributes["name"]);". 

namespace SMAS
{
class Profiles
{
    private XmlTextReader _profReader;
    private XmlDocument _profDoc;

    private const string Url = "http://localhost/teamprofiles.xml";
    private const string XPath = "/teams/team-profile";

    public XmlNodeList Teams{ get; private set; }
    private XmlAttributeCollection _attr;

    public ArrayList Team { get; private set; }

    public void GetTeams()
    {
        _profReader = new XmlTextReader(Url);
        _profDoc = new XmlDocument();

        _profDoc.Load(_profReader);
        Teams = _profDoc.SelectNodes(XPath);

        foreach (XmlNode xmlNode in Teams)
        {
            _attr.Append(xmlNode.Attributes["name"]);
        }
    }
}
}

the teamprofiles.xml file looks like 

  <teams>
    <team-profile name="Australia">
      <stats type="Test">
        <span>1877-2010</span>
        <matches>721</matches>
        <won>339</won>
        <lost>186</lost>
        <tied>2</tied>
        <draw>194</draw>
        <percentage>47.01</percentage>
      </stats>
      <stats type="Twenty20">
        <span>2005-2010</span>
        <matches>32</matches>
        <won>18</won>
        <lost>12</lost>
        <tied>1</tied>
        <draw>1</draw>
        <percentage>59.67</percentage>
      </stats>
    </team-profile>
    <team-profile name="Bangladesh">
      <stats type="Test">
        <span>2000-2010</span>
        <matches>66</matches>
        <won>3</won>
        <lost>57</lost>
        <tied>0</tied>
        <draw>6</draw>
        <percentage>4.54</percentage>
      </stats>
    </team-profile>
 </teams>

I am trying to extract names of all teams in an ArrayList. Then i'll extract all stats of all teams and display them in my application. Can you please help me about that null reference exception?

Upvotes: 0

Views: 1335

Answers (4)

R. Martinho Fernandes
R. Martinho Fernandes

Reputation: 234434

As others have said, you have to initialize _attr.

With what value?

A XmlAttributeCollection is returned by XmlElement.Attributes. If what you want is the attributes of an element, you can just use that property. If what you want is a "collection of XmlAttribute" but not forcibly a XmlAttributeCollection, you can declare it like this:

ICollection<XmlAttribute> _attr = new List<XmlAttribute>();

And then use ICollection<T>.Add instead of Append.

Or, use LINQ:

_attr = (from node in Teams
        select node.Attributes["name"]).ToList();

Upvotes: 1

Pharabus
Pharabus

Reputation: 6062

I cant see where you initialise private XmlAttributeCollection _attr;

you can try

 _profDoc.Load(_profReader);
_attr =  _profDoc.DocumentElement.Attributes;

Upvotes: 3

Marcelo Cantos
Marcelo Cantos

Reputation: 185852

You never initialize _attr. It's a null reference.

Upvotes: 3

Joren
Joren

Reputation: 14746

It doesn't seem like you ever assign anything to _attr, so of course it'll be null.

Upvotes: 0

Related Questions