CODEWITHSUNDEEP
c#generics
Graviton
Graviton

Reputation: 83326

Why Is It That Generics Constraint Can't Be Casted to Its Derived Type?

It is quite puzzling to find out that Generics Constraint Can't Be Casted to Its Derived Type.

Let's say I have the following code:

public abstract class BaseClass
{
    public int Version
    { get { return 1; } }

    public string FixString { get; set; }

    public BaseClass()
    {
        FixString = "hello";
    }

    public virtual int GetBaseVersion()
    {
        return Version;
    }
}

public class DeriveClass: BaseClass
{
    public new int Version
    { get { return 2; } }
}

And guess what, this method will return a compilation error:

    public void FreeConversion<T>(T baseClass)
    {
       if(baseClass.GetType()==typeof(DeriveClass)
        var derivedMe = (DeriveClass)baseClass;
    }

I would have to cast the baseClass to object first before I can cast it to DerivedClass, i.e., 

    public void FreeConversion<T>(T baseClass)
    {
       if(baseClass.GetType()==typeof(DeriveClass)
        var derivedMe = (DeriveClass)((object)baseClass);
    }

Seems to me pretty ugly. Why this is so?

Upvotes: 8

Views: 372

Answers (4)

this. __curious_geek
this. __curious_geek

Reputation: 43217

First of all, in your generic method the type T could be a vale type or reference type. And the reason why it allows you to do via 'Object' is that, you're simply doing boxing-unboxing which works for any type in system.

Secondly.it will be a terrible idea to convert/cast a baseclass object into a derived class. You're violating the mechanics of OOP.

If you really want to return an object of type derived from the base class, here's one way possible - the solution is pretty much similar to what Frank has offered.

//This is how you create a function in BaseClass that returns the collection 
//of DerivedTypes when called from an object of type derivedclass, no magic just Generics.

//**The BaseClass**
public class BaseClass<T>
    where T : BaseClass<T>
{
    public HashSet<T> GetHashSet()
    {
        HashSet<T> _hSet = new HashSet<T>();
        //do some work              
        //create a HashSet<T> and return;              
        return _hSet;
    }
}
//**The Derived Class**
public class DerivedClass : BaseClass<DerivedClass>
{
    //you have the method inherited.
}

Upvotes: 0

flq
flq

Reputation: 22859

As you already stated, the cheap trick is to first cast to object, then to the type you want to go. Ugly, but it works.

Apart from that, it may be that you are violating Liskov Substitution principle, nothing that will harm any animals but can drive your design towards unmaintainable code.

Third, a nice trick to let your base class expose the derived type is something like this:

public class Base<T> where T : Base<T> {
  T IAmDerived;
}

public class Derived : Base<Derived> { }

Upvotes: 1

Tomas Aschan
Tomas Aschan

Reputation: 60674

The answer is simple: the compiler can't know that T in your FreeConversion method can be converted to DeriveClass.

Upvotes: 3

user151323
user151323

Reputation:

First, you shouldn't be casting a base type variable to a derived type. It's not supposed to work, only the other way around.

Second, why it works via object, is because you remove the compile-time type checks. The compiler can check that a BaseType cannot be cast to DerivedType. But when a variable is object, the compiler leaves it assuming you know what you're doing. Even if it will compile, the code will then crash during execution.

Upvotes: 7

Related Questions