I am getting the following error Couldn't find Post with 'id'= and can't find a way around it?

Question

I am getting Couldn't find Post with 'id'= over and over again. I am trying to render Posts that were created by the signed in user to their profile page.

Here is my entire User_controller,

class UsersController < ApplicationController
before_action :set_user, only: [:show, :edit, :update, :destroy]
after_action :signed_in_after_register, only: :create 


def index
 @users = User.all

end

def profile 
  @user = User.find(session[:user_id]) unless session[:user_id] == ""
  redirect_to login_path, notice: "You're not logged in" unless @user 
  @post = Post.find(params[:id])
end 

def destroy
  @user = User.find(session[:user_id])
end

def welcome
  @user = User.find(session[:user_id])
end

def show
  @user = User.find(params[:user_id])
  @posts = @user.posts
end

def new
  @user = User.new
end

def create
  @user = User.new(user_params)

respond_to do |format|
  if @user.save
    format.html { redirect_to profile_path, notice: 'User was successfully created.' }
    format.json { render :show, status: :created, location: @user }
  else
        format.html { render :new }
        format.json { render json: @user.errors, status: :unprocessable_entity }
       end
      end
    end

  def update
    respond_to do |format|
      if @user.update(user_params)
        format.html { redirect_to @user, notice: 'User was successfully  updated.' }
        format.json { render :show, status: :ok, location: @user }
      else
    format.html { render :edit }
    format.json { render json: @user.errors, status: :unprocessable_entity }
   end
 end
end

  def destroy
    @user.destroy
    respond_to do |format|
      format.html { redirect_to users_url, notice: 'User was successfully   destroyed.' }
      format.json { head :no_content }
    end
  end

  private
        def set_user
          @user = User.find(params[:id])
  end
    def signed_in_after_register 
      session[:user_id] = @user.id 

    end
  def user_params
    params.require(:user).permit(:name, :password, :password_confirmation,  :email, :age, :profile_picture, :post)
  end
end

I also have the following in my Posts_controller,

class PostsController < ApplicationController
    def index
        @posts = Post.all.order('created_at DESC')
    end
    def new 
        @post = Post.new
    end
    def create 
        @post = Post.new(post_params)

      if @post.save 
          redirect_to @post 
      else
          render 'new'
     end
end
def show
    @post = Post.find(params[:id])

end
def edit
    @post = Post.find(params[:id])
end

def update
    @post = Post.find(params[:id])

    if @post.update(params[:post].permit(:body))
        redirect_to @post
    else
        render 'edit'
    end
end
def destroy
    @post = Post.find(params[:id])
    @post.destroy

    redirect_to posts_path
end

    private
    def post_params
        params.require(:post).permit(:body)
   end
end

And the following is in my routes file,

Rails.application.routes.draw do

  root 'welcome#welcome'

  get 'login' => 'sessions#login', :as => :login 

  get 'profile' => 'users#profile', :as => :profile

  post 'logging/user' => 'sessions#create'  

  get 'logout' => 'sessions#destroy', :as => :logout 

  get 'about' => 'about'

  resources :users

  resources  :posts

  get 'index' => 'posts#index'

  get 'register' => 'users#new', :as => :register

This is in my posts model,

class Post < ActiveRecord::Base
    belongs_to :user
    validates :body, presence: true
end

and this is in my users model

class User < ActiveRecord::Base
  has_secure_password
  validates :email, :name, presence: true, uniqueness: true 
  validates_inclusion_of :age, in: 10..100
  validates :password, presence: true 
  has_many :posts
  has_attached_file :profile_picture, :styles => { :medium => "300x300>",  :thumb => "300x200>" }, 
  :default_url => "app/assets/images/missing.png", 
  :path =>  ":rails_root/public/system/:class/:attachment/:id_partition/:style/:filename" 
  validates_attachment_content_type :profile_picture, :content_type => /\Aimage\/.*\Z/
end

If you could give me some advice on this it'd be very helpful! I've been stuck on this little problem for days!

Answer 1

Actually, you don't render user posts in the profile page: you have

@post = Post.find(params[:id])

in the profile action of your controller.

And you clearly don't have a post id param in your route.

Just replace this line by

@posts = @user.posts

like you do in the show action.

Also, I'm not sure you really need this custom profile action if you render the exact same thing in the show.