MrProgram
MrProgram

Reputation: 5242

Running exe with parameters doesn't work

var p = Process.Start(@"c:\PsTools\PsExec.exe", @"C:\Windows\System32\notepad.exe");
var err = p.StandardError.ReadToEnd();
var msg = p.StandardOutput.ReadToEnd();
lblStatusResponse.Text = "Err: " + err + "Msg: " + msg;

Why is my code not working?

I getting error:

System.InvalidOperationException: StandardError has not been redirected.

But when I add following:

p.StartInfo.RedirectStandardError = true;
var p = Process.Start(@"c:\PsTools\PsExec.exe", @"C:\Windows\System32\notepad.exe");) 

it still gets the same error.

The main problem is that I wanna execute a exe with arguments, but I can't get it to work.

Upvotes: 6

Views: 7924

Answers (4)

osama ellahi
osama ellahi

Reputation: 31

     Process proc = new Process();
     proc.StartInfo.FileName = "cmd.exe";
     proc.StartInfo.UseShellExecute = false;
     proc.StartInfo.RedirectStandardError = true;
     proc.StartInfo.RedirectStandardOutput = true;
     proc.StartInfo.Arguments = "/C " + command; //Enter your own command
     proc.Start();
     string output =proc.StandardOutput.ReadToEnd();

Upvotes: 0

Salem
Salem

Reputation: 784

I know this is not the same code you have but this is was the only working code I have , that will run external command/process in C# , and return all of it output/errors to the application main window

public void Processing()
{
    //Create and start the ffmpeg process
    System.Diagnostics.ProcessStartInfo psi = new ProcessStartInfo("ffmpeg")
    { // this is fully command argument you can make it according to user input 
        Arguments = "-y -i  '/mnt/Disk2/Video/Antina03.jpg' pp.mp4 ",
        RedirectStandardOutput = true,
        WindowStyle = System.Diagnostics.ProcessWindowStyle.Hidden,
        UseShellExecute = false,
        RedirectStandardError=true,
        RedirectStandardInput=true
    };
    System.Diagnostics.Process ischk;
    ischk = System.Diagnostics.Process.Start(psi);
    ischk.WaitForExit();
    ////Create a streamreader to capture the output of ischk
    System.IO.StreamReader ischkout = ischk.StandardOutput;
    ischk.WaitForExit();
    if (ischk.HasExited) // this condition very important to make asynchronous output  
    {
        string output = ischkout.ReadToEnd();
        out0 = output;
    }

    /// in case you got error message 
    System.IO.StreamReader iserror = ischk.StandardError;
    ischk.WaitForExit();
    if (ischk.HasExited)
    {
        string output = iserror.ReadToEnd();
        out0 = output;
    }

}

if you want to run this process just call the function Processing() BTW out0 are global variable so it can use out the function .

credit

I'm using MonoDevlop "C# devloping tool on Linux " and I get the output this way :-

public MainWindow() : base(Gtk.WindowType.Toplevel)
{
    Build();
    Processing();
    textview2.Buffer.Text = out0;

}

Upvotes: -1

Thorsten Dittmar
Thorsten Dittmar

Reputation: 56727

The following code generates a new p, this ignoring the settings you change in the previous instance:

var p = Process.Start(@"c:\PsTools\PsExec.exe", @"C:\Windows\System32\notepad.exe");) 

So it doesn't really matter whether you initialize p like this

p.StartInfo.RedirectStandardError = true;

or not.

What you need to do

You need to create a ProcessStartInfo object, configure it and then pass it to Process.Start.

ProcessStartInfo p = new ProcessStartInfo(@"c:\PsTools\PsExec.exe", @"C:\Windows\System32\notepad.exe");
p.UseShellExecute = false;
p.RedirectStandardError = true;
p.RedirectStandardOutput = true;

Process proc = Process.Start(p);

var err = proc.StandardError.ReadToEnd();
var msg = proc.StandardOutput.ReadToEnd();

Upvotes: 15

Adrian Salazar
Adrian Salazar

Reputation: 5319

Taken from MSDN: https://msdn.microsoft.com/en-us/library/system.diagnostics.process.standardoutput(v=vs.110).aspx

The StandardOutput stream has not been defined for redirection; ensure ProcessStartInfo.RedirectStandardOutput is set to true and ProcessStartInfo.UseShellExecute is set to false.

So remember to set those flags as instructed by MS.

Upvotes: 1

Related Questions