CODEWITHSUNDEEP
laravelcounteloquentdistinct
Inigo EC
Inigo EC

Reputation: 2328

Laravel Eloquent - distinct() and count() not working properly together

So I'm trying to get the number of distinct pids on a query, but the returned value is wrong.

This is what I try to do:

$ad->getcodes()->groupby('pid')->distinct()->count()

what returns the value "2", while the value it should return, should be "1".

As a workaround, I'm doing this:

count($ad->getcodes()->groupby('pid')->distinct()->get())

what works fine and returns "1"

Is there any rule where count and distinct cannot be on the same query? I find the workaround kind of "heavy", I would like to make the original query work :(

Upvotes: 138

Views: 607088

Answers (14)

Topsub
Topsub

Reputation: 11

In Laravel 9 i was able to get this working with using unique so it only pulls the latest times with unique IP addresses from my database.

This returns a number for me.

PageHistory::where('updated_at', '>=', Carbon::now()->subMinutes(5)->toDateTimeString())->get()->unique('ip_address')->count();

Upvotes: 0

ulas korpe
ulas korpe

Reputation: 39

Use something like this

DB::table('user_products')->select('user_id')->distinct()->pluck('user_id')->toArray();

Upvotes: 1

Suresh Bala
Suresh Bala

Reputation: 2362

The following should work

$ad->getcodes()->distinct()->count('pid');

Upvotes: 195

jc_anchor
jc_anchor

Reputation: 71

Based on Laravel docs for raw queries I was able to get count for a select field to work with this code in the product model. 

public function scopeShowProductCount($query)
{
    $query->select(DB::raw('DISTINCT pid, COUNT(*) AS count_pid'))
          ->groupBy('pid')
          ->orderBy('count_pid', 'desc');
}

This facade worked to get the same result in the controller:

$products = DB::table('products')->select(DB::raw('DISTINCT pid, COUNT(*) AS count_pid'))->groupBy('pid')->orderBy('count_pid', 'desc')->get();

The resulting dump for both queries was as follows:

#attributes: array:2 [
  "pid" => "1271"
  "count_pid" => 19
],
#attributes: array:2 [
  "pid" => "1273"
  "count_pid" => 12
],
#attributes: array:2 [
  "pid" => "1275"
  "count_pid" => 7
]

Upvotes: 3

Shahrukh Anwar
Shahrukh Anwar

Reputation: 2632

You can use the following way to get the unique data as per your need as follows,

$data = $ad->getcodes()->get()->unique('email');

$count = $data->count();

Hope this will work.

Upvotes: 13

Zoon
Zoon

Reputation: 1088

Anyone else come across this post, and not finding the other suggestions to work?

Depending on the specific query, a different approach may be needed. In my case, I needed either count the results of a GROUP BY, e.g.

SELECT COUNT(*) FROM (SELECT * FROM a GROUP BY b)

or use COUNT(DISTINCT b):

SELECT COUNT(DISTINCT b) FROM a

After some puzzling around, I realised there was no built-in Laravel function for either of these. So the simplest solution was to use use DB::raw with the count method.

$count = $builder->count(DB::raw('DISTINCT b'));

Remember, don't use groupBy before calling count. You can apply groupBy later, if you need it for getting rows.

Upvotes: 25

xiaoxiao
xiaoxiao

Reputation: 1

try this

$ad->getcodes()->groupby('pid')->distinct()->count('pid')

Upvotes: -3

Daniel Santos
Daniel Santos

Reputation: 457

$solution = $query->distinct()
            ->groupBy
            (
                [
                    'array',
                    'of',
                    'columns',
                ]
            )
            ->addSelect(
                [
                    'columns',
                    'from',
                    'the',
                    'groupby',
                ]
            )
            ->get();

Remember the group by is optional,this should work in most cases when you want a count group by to exclude duplicated select values, the addSelect is a querybuilder instance method.

Upvotes: 3

Karl Anthony Baluyot
Karl Anthony Baluyot

Reputation: 176

Distinct do not take arguments as it adds DISTINCT in your sql query, however, you MAY need to define the column name that you'd want to select distinct with. Thus, if you have Flight->select('project_id')->distinct()->get() is equialent to SELECT DISTINCT 'project_id' FROM flights and you may now add other modifiers like count() or even raw eloquent queries.

Upvotes: 1

Andrew
Andrew

Reputation: 20061

A more generic answer that would have saved me time, and hopefully others:

Does not work (returns count of all rows):

DB::table('users')
            ->select('first_name')
            ->distinct()
            ->count();

The fix:

DB::table('users')
            ->distinct()
            ->count('first_name');

Upvotes: 48

J Foley
J Foley

Reputation: 1099

Wouldn't this work?

$ad->getcodes()->distinct()->get(['pid'])->count();

See here for discussion..

Upvotes: 1

Brett
Brett

Reputation: 2010

I came across the same problem.

If you install laravel debug bar you can see the queries and often see the problem

$ad->getcodes()->groupby('pid')->distinct()->count()

change to 

$ad->getcodes()->distinct()->select('pid')->count()

You need to set the values to return as distinct. If you don't set the select fields it will return all the columns in the database and all will be unique. So set the query to distinct and only select the columns that make up your 'distinct' value you might want to add more. ->select('pid','date') to get all the unique values for a user in a day

Upvotes: 4

Matt McDonald
Matt McDonald

Reputation: 5050

I had a similar problem, and found a way to work around it.

The problem is the way Laravel's query builder handles aggregates. It takes the first result returned and then returns the 'aggregate' value. This is usually fine, but when you combine count with groupBy you're returning a count per grouped item. So the first row's aggregate is just a count of the first group (so something low like 1 or 2 is likely).

So Laravel's count is out, but I combined the Laravel query builder with some raw SQL to get an accurate count of my grouped results.

For your example, I expect the following should work (and let you avoid the get):

$query = $ad->getcodes()->groupby('pid')->distinct();
$count = count(\DB::select($query->toSql(), $query->getBindings()));

If you want to make sure you're not wasting time selecting all the columns, you can avoid that when building your query:

 $query = $ad->select(DB::raw(1))->getcodes()->groupby('pid')->distinct();

Upvotes: 7

Sushant Yadav
Sushant Yadav

Reputation: 726

This was working for me so Try This: $ad->getcodes()->distinct('pid')->count()

Upvotes: -2

Related Questions