CODEWITHSUNDEEP
angularjspromiseangular-promise
Kyeotic
Kyeotic

Reputation: 19847

Angular logs error to console before raising promise.catch

I feel like I am going a little crazy, but Angular appears to throw an error for a promise even if I have a catch defined. It throws the error to the console, then allows the catch to run.

Here is a super-simple fiddle

The test code:

$q.when(1)
    .then(function() {
        throw new Error("test");
    }).catch(function(error) {
        console.log('error caught', error);
    });

The resulting console

enter image description here (dirty liar!)

Here is a fiddle showing what I expect to happen: the catch is raised, and no other error is logged to the console. Did I fail to configure something, or does Angular implement a broken promise spec?

Upvotes: 6

Views: 2091

Answers (1)

André Werlang
André Werlang

Reputation: 5944

angular by default logs all errors to console.

angular also provides a way to override this behavior. $exceptionHandler is a global service that is given a chance to process any exceptions ($http, errors during $digest, etc).

If you add this piece of code:

myApp.factory('$exceptionHandler', function() {
  return function(exception, cause) {
    exception.message += ' (caused by "' + cause + '")';
    //throw exception;
  };
});

Then all errors would just stop further logging. Would process catch() handlers though. Updated fiddle: http://jsfiddle.net/5jjx5rn3/

UPDATE:

As pointed by dnc253 in the comments, there's a better way if you intend to actually override an angularjs service. Even not being the focus of this question, it's better to know that simply declaring a service with the same name, in whatever module, the service is fully replaced (last-in wins). If one wants to add functionality around the original service, a decorator is the right choice.

Upvotes: 7

Related Questions