CODEWITHSUNDEEP
iosswiftnsnotifications
Clement Joseph
Clement Joseph

Reputation: 1293

Where to remove observer for NSNotification in Swift?

Where should I remove the observer for NSNotification in Swift, since viewDidUnload and dealloc() are unavailable?

Upvotes: 103

Views: 107691

Answers (10)

user15564823
user15564823

Reputation: 

deinit {
    //Remove Observer 
    NotificationCenter.default.removeObserver(self)
}

Upvotes: 3

Pablo Ruan
Pablo Ruan

Reputation: 1791

You can use three methods:

  1. after popViewController, back navigationController or dismissViewControllerAnimated:

     deinit {
     print("Remove NotificationCenter Deinit")
     NSNotificationCenter.defaultCenter().removeObserver(self)
 }

  2. viewDidDisappear, remove after it is already the next view controller:

     override func viewDidDisappear(animated: Bool) {
     NSNotificationCenter.defaultCenter().removeObserver(self)
 }

  3. viewWillDisappear - before opening the next view:

     override func viewWillDisappear(animated: Bool) {
     NSNotificationCenter.defaultCenter().removeObserver(self)
 }

Swift 5.0 syntax:

NotificationCenter.default.removeObserver(self)

Upvotes: 76

Simran Singh Sandhu
Simran Singh Sandhu

Reputation: 501

Swift 5

I have a chat application, so whenever I go from my ChatLogViewController to some other viewController and then comeback, I have 1 extra Observer of my keyboard notification. To remove that I remove all the observers when I change my viewController or disappear from my chatLogViewController.

override func viewDidDisappear(_ animated: Bool) {    
    super.viewDidDisappear(animated)

    NotificationCenter.default.removeObserver(self)
}

Upvotes: 3

Pawel Molodkin
Pawel Molodkin

Reputation: 132

deinit {
    NotificationCenter.default.removeObserver(self)
}

Upvotes: 2

Ashim Dahal
Ashim Dahal

Reputation: 1147

In Swift 4.2, this is one of the way you can remove observer

deinit {
    NotificationCenter.default.removeObserver(self, name: Notification.Name.Identifier, object: nil)
}

setup addObserver notification in viewDidLoad class

override func viewDidLoad() {
    super.viewDidLoad()
    NotificationCenter.default.addObserver(self, selector: #selector(didReceivedItemDetail), name: Notification.Name.Identifier, object: nil)
}

Upvotes: 27

Nikola Milicevic
Nikola Milicevic

Reputation: 2975

As of iOS 9 (and OS X 10.11), you don't need to remove observers yourself, if you're not using block based observers though. The system will do it for you, since it uses zeroing-weak references for observers, where it can.

And if you are using block based observers, make sure you capture self weakly using [weak self] in the closure's capture list, and remove observer in deinit method. If you don't use weak reference to self, deinit method (and thus removal of that observer) will never be called since Notification Center will hold a strong reference to it indefinitely.

More info can be found at Foundation Release Notes for OS X v10.11 and iOS 9.

If the observer is able to be stored as a zeroing-weak reference the underlying storage will store the observer as a zeroing weak reference, alternatively if the object cannot be stored weakly (i.e. it has a custom retain/release mechanism that would prevent the runtime from being able to store the object weakly) it will store the object as a non-weak zeroing reference. This means that observers are not required to un-register in their deallocation method.

Block based observers via the -[NSNotificationCenter addObserverForName: object: queue: usingBlock] method still need to be un-registered when no longer in use since the system still holds a strong reference to these observers.

Upvotes: 170

Mehul Patel
Mehul Patel

Reputation: 23053

Use below method which functions same as dealloc.

deinit {
    // Release all resources
    // perform the deinitialization
}

A deinitializer is called immediately before a class instance is deallocated. You write deinitializers with the deinit keyword, similar to how intializers are written with the init keyword. Deinitializers are only available on class types.

Swift Deinitializer

Upvotes: 80

Ankit khare
Ankit khare

Reputation: 42

It is also good if you add your observer in viewWillAppear() and remove them in viewWillDisappear()

Upvotes: 0

Guy Daher
Guy Daher

Reputation: 5601

I also want to point out that you should use this method:

func addObserver(_ observer: Any, selector aSelector: Selector, name aName: NSNotification.Name?, object anObject: Any?)

Instead of 

func addObserver(forName name: NSNotification.Name?, object obj: Any?, queue: OperationQueue?, using block: @escaping (Notification) -> Void) -> NSObjectProtocol

The latter will not remove the observer (Ran into this problem recently). The former will remove the observer if you are using iOS9.

Upvotes: 4

pmick
pmick

Reputation: 469

Swift provides a deinit method that is called on instances of classes before they are destroyed.

https://developer.apple.com/library/ios/documentation/Swift/Conceptual/Swift_Programming_Language/Deinitialization.html

Upvotes: 4

Related Questions