CODEWITHSUNDEEP
javadatetimecalendartimezone
user346034
user346034

Reputation:

Changing timezone without changing time in Java

I'm receiving a datetime from a SOAP webservice without timzone information. Hence, the Axis deserializer assumes UTC. However, the datetime really is in Sydney time. I've solved the problem by substracting the timezone offset:

Calendar trade_date = trade.getTradeDateTime();
TimeZone est_tz = TimeZone.getTimeZone("Australia/Sydney");
long millis = trade_date.getTimeInMillis() - est_tz.getRawOffset();
trade_date.setTimeZone( est_tz );
trade_date.setTimeInMillis( millis );

However, I'm not sure if this solution also takes daylight saving into account. I think it should, because all operations are on UTC time. Any experiences with manipulating time in Java? Better ideas on how to solve this problem?

Upvotes: 16

Views: 23758

Answers (8)

Anurag Moudgil
Anurag Moudgil

Reputation: 19

public Calendar replaceTimezone(String targetTimezoneID, String sourceTimezoneID, Date sourceDate) {
        TimeZone sourceTZ = TimeZone.getTimeZone(sourceTimezoneID);
        int sourceTZOffsetToGMT = sourceTZ.getOffset(sourceDate.getTime());
        
        TimeZone targetTZ = TimeZone.getTimeZone(targetTimezoneID);
        Calendar targetCal = Calendar.getInstance();
        targetCal.setTime(sourceDate);
        targetCal.setTimeZone(targetTZ);
        Date preTargetDate = targetCal.getTime();
        int targetTZOffsetToGMT = targetTZ.getOffset(preTargetDate.getTime());
        
        int adjustOffset = sourceTZOffsetToGMT - targetTZOffsetToGMT;
        targetCal.add(Calendar.MILLISECOND, adjustOffset);
        
        return targetCal;
    }

Upvotes: 0

Paul Wagland
Paul Wagland

Reputation: 29116

I pity the fool who has to do dates in Java.

What you have done will almost certainly go wrong around the daylight savings transitions. The best way to to it is probably to create a new Calendar object, set the Timezone on it, and then set all of the fields individually, so year, month, day, hour, minute, second, getting the values from the Date object.

Edit:
To keep the everyone happy, you should probably do this:

Calendar utcTime = Calendar.getInstance(TimeZone.getTimeZone("UTC"));
Calendar sydneyTime = Calendar.getInstance(TimeZone.getTimeZone("Australia/Sydney");
utcTime.setTime(trade_date);
for (int i = 0; i < Calendar.FIELD_COUNT; i++) {
  sydneyTime.set(i, utcTime.get(i));
}

Then you won't be using any deprecated methods.

Upvotes: 22

Olesia
Olesia

Reputation: 11

 @Test
 public void tzTest() {
     SimpleDateFormat df = new SimpleDateFormat("yyyy-MM-dd HH:mm:ss.SSS Z");
     TimeZone tz1 = TimeZone.getTimeZone("Europe/Moscow");
     Calendar cal1 = Calendar.getInstance(tz1);
     long l1 = cal1.getTimeInMillis();
     df.setTimeZone(tz1);
     System.out.println(df.format(cal1.getTime()));
     System.out.println(l1);
     TimeZone tz2 = TimeZone.getTimeZone("Africa/Douala");
     Calendar cal2 = Calendar.getInstance(tz2);
     long l2 = l1 + tz1.getRawOffset() - tz2.getRawOffset();
     cal2.setTimeInMillis(l2);
     df.setTimeZone(tz2);
     System.out.println(df.format(cal2.getTime()));
     System.out.println(l2);
     assertNotEquals(l2, l1);
 }


Running CalendarTest
2016-06-30 19:09:16.522 +0300
1467302956522
2016-06-30 19:09:16.522 +0100
1467310156522
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.137 sec

Upvotes: 1

Basil Bourque
Basil Bourque

Reputation: 338346

Are you getting an ISO 8601 style string from that messed-up Web Service? If so, the Joda-Time 2.3 library makes this very easy.

If you are getting an ISO 8601 string without any time zone offset, you pass a time zone object to the DateTime constructor.

DateTimeZone timeZone = DateTimeZone.forID( "Australia/Sydney" );
String input = "2014-01-02T03:00:00"; // Note the lack of time zone offset at end.
DateTime dateTime = new DateTime( input, timeZone );

Dump to console…

System.out.println( "dateTime: " + dateTime );

When run…

dateTime: 2014-01-02T03:00:00.000+11:00

Upvotes: 1

Timo Westk&#228;mper
Timo Westk&#228;mper

Reputation: 22180

However, I'm not sure if this solution also takes daylight saving into account. I think it should, because all operations are on UTC time.

Yes, you should take the daylight saving into account, since it affects the offset to UTC.

Any experiences with manipulating time in Java? Better ideas on how to solve this problem?

Joda-Time is a better time API. Maybe the following snippet could be of help :

DateTimeZone zone; // TODO : get zone
DateTime fixedTimestamp = new DateTime(year, monthOfYear, dayOfMonth, hourOfDay, minuteOfHour, secondOfMinute, millisOfSecond, zone);

JodaTime types are immutable which is also a benefit.

Upvotes: 3

Mark Elliot
Mark Elliot

Reputation: 51

I want to thank the person for responce 6. This was a great start for me and an approach I did not consider. There are some addtional steps required to bring it to production code level. In particular observe the steps required for DST_OFFSET and ZONE_OFFSET. I want to share the solution I came up with.

This takes the time from the input Calendar object, copies it to the output time, sets the new time zone to the output. This is used when taking time literally from the database and setting the Time Zone without changing the time.

public static Calendar setNewTimeZoneCopyOldTime( Calendar inputTime, 
        TimeZone timeZone ) {
    if( (inputTime == null) || (timeZone == null) ) { return( null ); }

    Calendar outputTime = Calendar.getInstance( timeZone );
    for( int i = 0; i < Calendar.FIELD_COUNT; i++ ) {
        if( (i != Calendar.ZONE_OFFSET) && (i != Calendar.DST_OFFSET) ) { 
            outputTime.set(i, inputTime.get(i));
        }
    }

    return( (Calendar) outputTime.clone() );
}

Upvotes: 5

razedk
razedk

Reputation: 21

I normally do it this way

Calendar trade_date_utc = trade.getTradeDateTime();
TimeZone est_tz = TimeZone.getTimeZone("Australia/Sydney");
Calendar trade_date = Calendar.GetInstance(est_tz);
trade_date.setTimeInMillis( millis );

Upvotes: 2

user346034
user346034

Reputation:

I've decided to reparse the datetime string received with the correct time zone set. This should also consider daylight saving:

public class DateTest {

    private static SimpleDateFormat soapdatetime = new SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss.SSS");

    /**
     * @param args
     */
    public static void main(String[] args) {
        TimeZone oztz = TimeZone.getTimeZone("Australia/Sydney");
        TimeZone gmtz = TimeZone.getTimeZone("GMT");
        Calendar datetime = Calendar.getInstance( gmtz );

        soapdatetime.setTimeZone( gmtz );
        String soap_datetime = soapdatetime.format( datetime.getTime() );
        System.out.println( soap_datetime );

        soapdatetime.setTimeZone( oztz );
        datetime.setTimeZone( oztz );
        try {
            datetime.setTime(
                    soapdatetime.parse( soap_datetime )
            );
        } catch (ParseException e) {
            e.printStackTrace();
        }

        soapdatetime.setTimeZone( gmtz );
        soap_datetime = soapdatetime.format( datetime.getTime() );
        System.out.println( soap_datetime );
    }
}

Upvotes: -1

Related Questions