CODEWITHSUNDEEP
javascriptangularjsfirebaseangularfire
itsclarke
itsclarke

Reputation: 8972

Firebase API issue with AngularJS website example project

Beginning to dive into AngularJS so I went to their website, but got stuck on the wire up a backend portion where Angular uses Firebase. The first issue came from the ordering of dependencies:

angular.module('project', ['ngRoute', 'firebase'])

changed to

angular.module('project', ['firebase', 'ngRoute'])

But now it's telling my that $add, in my $scope.save call, is undefined.

Similar $add undefined questions are here and here, but neither seem to apply.

Note: I'm running node's http-server, so I'm assuming it's not a localhost problem.

Scripts

angular.module('project', ['firebase', 'ngRoute'])

.value('fbURL', 'https://unique-url-yay.firebaseio.com/')
.service('fbRef', function(fbURL) {
  return new Firebase(fbURL)
})
.service('fbAuth', function($q, $firebase, $firebaseAuth, fbRef) {
  var auth;
  return function () {
      if (auth) return $q.when(auth);
      var authObj = $firebaseAuth(fbRef);
      if (authObj.$getAuth()) {
        return $q.when(auth = authObj.$getAuth());
      }
      var deferred = $q.defer();
      authObj.$authAnonymously().then(function(authData) {
          auth = authData;
          deferred.resolve(authData);
      });
      return deferred.promise;
  }
})

.service('Projects', function($q, $firebase, fbRef, fbAuth) {
  var self = this;
  this.fetch = function () {
    if (this.projects) return $q.when(this.projects);
    return fbAuth().then(function(auth) {
      var deferred = $q.defer();
      var ref = fbRef.child('projects/' + auth.auth.uid);
      var $projects = $firebase(ref);
      ref.on('value', function(snapshot) {
        if (snapshot.val() === null) {
          $projects.$set(window.projectsArray);
        }
        self.projects = $projects.$asArray();
        deferred.resolve(self.projects);
      });
      return deferred.promise;
    });
  };
})

.config(function($routeProvider) {
  $routeProvider
    .when('/', {
      controller:'ListCtrl',
      templateUrl:'list.html',
      resolve: {
        projects: function (Projects) {
          return Projects.fetch();
        }
      }
    })
    .when('/edit/:projectId', {
      controller:'EditCtrl',
      templateUrl:'detail.html'
    })
    .when('/new', {
      controller:'CreateCtrl',
      templateUrl:'detail.html'
    })
    .otherwise({
      redirectTo:'/'
    });
})

.controller('ListCtrl', function($scope, projects) {
  $scope.projects = projects;
})

.controller('CreateCtrl', function($scope, $location, Projects) {
  $scope.save = function() {
      Projects.projects.$add($scope.project).then(function(data) {
          $location.path('/');
      });
  };
})

.controller('EditCtrl',
  function($scope, $location, $routeParams, Projects) {
    var projectId = $routeParams.projectId,
        projectIndex;

    $scope.projects = Projects.projects;
    projectIndex = $scope.projects.$indexFor(projectId);
    $scope.project = $scope.projects[projectIndex];

    $scope.destroy = function() {
        $scope.projects.$remove($scope.project).then(function(data) {
            $location.path('/');
        });
    };

    $scope.save = function() {
        $scope.projects.$save($scope.project).then(function(data) {
           $location.path('/');
        });
    };
});

Index.html

<!DOCTYPE html>
<html>
  <head>
    <title>Angular</title>
    <script src="https://ajax.googleapis.com/ajax/libs/angularjs/1.3.14/angular.min.js"></script>
    <script src="https://ajax.googleapis.com/ajax/libs/angularjs/1.3.14/angular-resource.min.js">
    </script>
    <script src="https://ajax.googleapis.com/ajax/libs/angularjs/1.3.14/angular-route.min.js">
   </script>
    <script src="https://cdn.firebase.com/js/client/2.0.4/firebase.js"></script>
    <script src="https://cdn.firebase.com/libs/angularfire/0.9.0/angularfire.min.js"></script>
    <script src="scripts.js" type="text/javascript"></script>
    <link href="https://cdnjs.cloudflare.com/ajax/libs/twitter-bootstrap/3.3.2/css/bootstrap.min.css" rel="stylesheet">
  </head>
  <body style="padding:20px;">
    <div ng-app="project" class="ng-scope"></div>
      <div ng-view></div>
  </body>
</html>

Upvotes: 1

Views: 672

Answers (1)

sbolel
sbolel

Reputation: 3526

Alright, a few things are going on here:

Suggestions

  1. AngularFire was updated to 1.1.1 and $firebase is now deprecated. Use $firebaseObject and $firebaseArray instead.

  2. There is no need to do all that stuff in your Projects service and return a promise. $firebaseObject and $firebaseArray return promises.

Example

Check out this PLNKR I made showing a working version of what you're trying to accomplish.

  • It's tied to one of my public Firebase instances.
  • You can create a new piece of data and see it on the home page.

JavaScript:

(function(angular) {
  angular.module('project', ['firebase', 'ngRoute'])
  .value('fbURL', 'https://sb-plnkr.firebaseio.com/so:28942661')

  .service('fbRef', function(fbURL) {
    return new Firebase(fbURL)
  })

  .service('fbAuth', function($q, $firebaseAuth, fbRef) {
    var auth;
    return function () {
      if (auth) return $q.when(auth);
      var authObj = $firebaseAuth(fbRef);
      if (authObj.$getAuth()) {
        return $q.when(auth = authObj.$getAuth());
      }
      var deferred = $q.defer();
      authObj.$authAnonymously().then(function(authData) {
          auth = authData;
          deferred.resolve(authData);
      });
      return deferred.promise;
    }
  })

  .service('Projects', function($q, $firebaseArray, fbRef) {
    this.sync = $firebaseArray(fbRef);
    this.sync.$loaded().then(function(data) {
      var projects = data;
    });
    return this.sync;
  })

  .controller('ListCtrl', function($scope, $location, Projects) {
    Projects.$loaded().then(function(data){
      $scope.projects = data;
    });
  })

  .controller('CreateCtrl', function($scope, $location, Projects) {
    console.log("CreateCtrl");
    $scope.save = function() {
      console.debug("Adding");
      if ($scope.project && $scope.project.content !== '') {
        Projects.$add($scope.project).then(function(ref) {
          console.log("Added ref",ref);
          $location.path('/');
        }).catch(function(errorObject){
          console.error(errorObject);
        });
      } else {
        alert("You have to enter something.");
      }
    };
  })

  .controller('EditCtrl',function($scope, $location, $routeParams, Projects) {
    var projectId = $routeParams.projectId,
        projectIndex;

    $scope.init = function(){
      Projects.$loaded().then(function(data) {
        $scope.projects = data;
        console.info("EditCtrl - Projects.$loaded():",data);
        projectIndex = $scope.projects.$indexFor(projectId);
        $scope.project = $scope.projects[projectIndex];
      });
    }

    $scope.destroy = function() {
      $scope.projects.$remove($scope.project).then(function(data) {
        $location.path('/');
      });
    };

    $scope.save = function() {
      $scope.projects.$save($scope.project).then(function(data) {
       $location.path('/');
      });
    };
  })

  .config(function($routeProvider, $locationProvider) {
    $routeProvider
      .when('/', {
        controller:'ListCtrl',
        templateUrl:'list.html'
      })
      .when('/edit/:projectId', {
        controller:'EditCtrl',
        templateUrl:'detail.html'
      })
      .when('/new', {
        controller:'CreateCtrl',
        templateUrl:'create.html'
      })
      .otherwise({
        redirectTo:'/'
      });

      $locationProvider.html5Mode(true);
  });
})(window.angular);

HTML:

(index.html)

<body style="padding:20px;">
  <div ng-app="project" ng-controller="EditCtrl">
    <a href="new">New</a>
    <div ng-view></div>
  </div>
</body>

(create.html)

<h2>Create</h2>
<button ng-click="save()">Save</button>

(list.html)

<h2>List</h2>
<div ng-repeat="(key,data) in projects">
  <span>$scope.projects[<span ng-bind="key"></span>].content : </span>
  <span ng-bind="data.content"></span>
</div>
<h2>Object Debug</h2>
<pre ng-bind="projects | json"></pre>

Hope that helps!

Upvotes: 2

Related Questions