Edit /Update with Web API Repository Pattern

Question

I'm trying to work out the very basics of updating my database using a Web API Controller that is backed by a repository pattern. So far I have everything working POST, GET, DELETE (Create, Read, Delete). But I'm missing the Update.

Below is my angular code, I'm not going to post the Angular Views/Templates, but just know that they do bind and they work just fine. My problem is only on the Edit View, where I try to update using the vm.save function. My save function works fine on the Angular side, but I'm not sure what to do on the Web API & Repository side. You will see that my code to get this working is very basic bare bones. I have all of the code pages from my project in a gist here:

All Files in Gist

Just in case you want to see the big picture, otherwise I will just put here the few pages where I am having trouble getting the Edit/Update methods to work in using http.put with Angular Controller, Web API Controller & Repository.

WORKING Angular Edit Controller:

function editFavoriteController($http, $window, $routeParams) {
    var vm = this;

    var url = "/api/favorites/" + $routeParams.searchId;
    $http.get(url)
        .success(function (result) {
            vm.search = result[0];
        })
        .error(function () {
            alert('error/failed');
        })
        .then(function () {
            //Nothing
        });

    vm.update = function (id) {
        var updateUrl = "/api/favorites/" + id;
        $http.put(updateUrl, vm.editFavorite)
            .success(function (result) {
                var editFavorite = result.data;
                //TODO: merge with existing favorites
                //alert("Thanks for your post");
            })
            .error(function () {
                alert("Your broken, go fix yourself!");
            })
            .then(function () {
                $window.location = "#/";
            });
    };
};

NOT WORKING Web API Controller

public HttpResponseMessage Put(int id,[FromBody]Search editFavorite)
{
    if (_favRepo.EditFavorite(id, editFavorite) && _favRepo.Save())
    {
        return Request.CreateResponse(HttpStatusCode.Created, editFavorite);
    }
    return Request.CreateResponse(HttpStatusCode.BadRequest);
}

NOT WORKING Repository

public bool EditFavorite(int id, Search editFavorite)
{
        try
    {
        var search = _ctx.Search.FirstOrDefault(s => s.SearchId == id);

        search(editFavorite).State = EntityState.Modified;
        return true;
    }
    catch
    {
        var item = "";
    }
}

WORKING Interface

bool EditFavorite(int id, Search newSearch);

Again, my only problems are figuring out what to do for the update in the WebAPI FavoritesController and FavoritesRepository. I have example of how I have done everything else in the Gist, so I'm hoping someone might be able to help me out. I'm just hitting a wall of what I know how to do in Web API.

Answer 1

Fixed Code:

public HttpResponseMessage Put(int id,[FromBody]Search editFavorite)
{
    if (_favRepo.EditFavorite(id, editFavorite))
    {
        _favRepo.Save()  
        return Request.CreateResponse(HttpStatusCode.Created, editFavorite);
    }
    return Request.CreateResponse(HttpStatusCode.BadRequest);
}

I am also posting code which should work fine for handling edit on server side using WEB API and Repository Pattern.

WebAPI Controller:

public HttpResponseMessage Put(int id,[FromBody]Search editFavorite)
{
    if (!ModelState.IsValid || id != editFavorite.Id)
    {
        return Request.CreateResponse(HttpStatusCode.BadRequest);
    }
    db.EditFavorite(editFavorite);
    try
    {
        db.Save();  
    }
    catch (DbUpdateConcurrencyException)
    {
        if (!db.SearchExists(id))
        {
            return Request.CreateResponse(HttpStatusCode.NotFound);
        }
        else
        {
            throw;
        }
    }
    return Request.CreateResponse(HttpStatusCode.Created, editFavorite);
}

Repository Method:

public void EditFavorite(Search editFavorite)
{
    db.Entry(editFavorite).State = EntityState.Modified;
}

public void Save()
{
    db.SaveChanges();
}

public bool SearchExists(int id)
{
    return db.Search.Count(e => e.Id == id) > 0;
}

Modify Interface:

void Save();
void EditFavorite(Search newSearch);
bool SearchExists(int id);

Edit:

I have made some changes so that only operations that are carried out on your db context is done in repository layer (Data Layer) and the error checking is done in the WEB API Controller.

Suggestion:

You should inherit IDisposable on the interface and implement it your repository class so that your entities are properly disposed...

public interface IFavoritesRepository : IDisposable
{
    // code here
}


public class FavoritesRepository : IFavoritesRepository
{
    // code here
    private bool disposed = false;

    protected virtual void Dispose(bool disposing)
    {
        if (!this.disposed)
        {
            if (disposing)
            {
                db.Dispose();
            }
        }
        this.disposed = true;
    }

    public void Dispose()
    {
        Dispose(true);
        GC.SuppressFinalize(this);
    }
}