CODEWITHSUNDEEP
javalogicconditional-operatorshort-circuiting
Aequitas
Aequitas

Reputation: 2265

Why is the conditional (ternary) operator evaluated in a logical AND when the lhs is false

return super.isAvailable() && expander != null 
    && rightNotLeft ? !expander.isExpandedRight() : expander.isExpandedRight();

My problem was that when expander was null I was getting a null pointer exception. But I didn't think that this should happen since expander!=null is being evaluated to false and since ANDs are being used the entire expression should short circuit and return false.

return super.isAvailable() && expander != null 
    && (rightNotLeft ? !expander.isExpandedRight() : expander.isExpandedRight());

The above code (adding the parentheses) solved the problem. However this does not make sense to me as no matter what happens in the conditional operator there is no way to return true so shouldn't it short circuit?

Thank you for your responses.

Upvotes: 1

Views: 326

Answers (1)

Marvin
Marvin

Reputation: 14415

This is due to operator precedence. Your condition without explicit parentheses is actually evaluated like

return (super.isAvailable() && expander != null 
    && rightNotLeft) ? !expander.isExpandedRight() : expander.isExpandedRight();

Upvotes: 1

Related Questions