CODEWITHSUNDEEP
java
joejoethemonkey
joejoethemonkey

Reputation: 63

Loading and saving files in a text based game (java)

So, i'm trying to save my player data onto a txt file, then load the data from the text from when the game is opened again, but its not working, I get it to save while in the game, but when I close the game, and open it back up its no longer saved, and it has all the default data in the game, and in the file...

Here is the some of the code from the game (Sorry it's in pastebin, I thought i might be too long to just paste it into here.)

I am in need of some assistance, trying to get it to load from the text document, and when the game opens, not resetting the text document into its default settings.

Upvotes: 1

Views: 3849

Answers (4)

joejoethemonkey
joejoethemonkey

Reputation: 63

So, I was fiddling around with some things, and I did it! So, the problem was, that i would load it from the save data, then write over it, then load it again, for some reason, it would do the whole Save.java 2 times and just save over it, but I put them all as public static voids and instead of calling the whole Constructor, I call them by individual methods by where and what they need to do, which seem to work great! Thank you all for all your help, it helped a lot!

Upvotes: 0

user3093783
user3093783

Reputation:

If you do not mind it, then using xstream and apache fileutils is an excellent solution and less coding. I am just sharing my thoughts. 

import org.apache.commons.io.FileUtils;
import com.thoughtworks.xstream.XStream;

//saving your data
XStream xstream=new XStream(new DOMDriver());
String xml = xstream.toXML(yourGambeObj);
FileUtils.writeStringToFile(new File("yourfilename", xml);

//reading your data
Game gameData=xstream.fromXML(new File("yourfilename"),Game.class);

//now you can use access your methods n attribute. no conversion as you did in serialization.

Please download and add these jars.XStream & Apache Commons IO

Upvotes: 0

Ubica
Ubica

Reputation: 1051

I think this part is the problem...

private void readPlayer(String filePath) {
    File inputFile;
    BufferedReader inputReader;

    try {
        inputFile = new File(filePath);
        inputReader = new BufferedReader(new FileReader(inputFile));

        Game.hp = saveInfo[0];
        Game.level = saveInfo[1];
        Game.mana = saveInfo[2];
        Game.expTotal = saveInfo[3];
        Game.goldTotal = saveInfo[4];
        Game.arrow = saveInfo[5];
        Game.shuriken = saveInfo[6];
        Game.bomb = saveInfo[7];
        Game.hpPotion = saveInfo[8];
        Game.mpPotion = saveInfo[9];
        Game.potion = saveInfo[10];
        Game.items = saveInfo[11];

        for (int i = 0; i < saveInfo.length; i++) {
            saveInfo[i] = Integer.parseInt(inputReader.readLine());
        }

        inputReader.close();

    } catch (Exception e) {
        e.printStackTrace();
    }

}

put these lines

for (int i = 0; i < saveInfo.length; i++) {
    saveInfo[i] = Integer.parseInt(inputReader.readLine());
}

before

Game.hp = saveInfo[0];
Game.level = saveInfo[1];
Game.mana = saveInfo[2];
Game.expTotal = saveInfo[3];
Game.goldTotal = saveInfo[4];
Game.arrow = saveInfo[5];
Game.shuriken = saveInfo[6];
Game.bomb = saveInfo[7];
Game.hpPotion = saveInfo[8];
Game.mpPotion = saveInfo[9];
Game.potion = saveInfo[10];
Game.items = saveInfo[11];

in order to read the file before setting the game values...

Upvotes: 1

Sam
Sam

Reputation: 101

The issue is in Save.savePlayer()

At the beginning you declare saveInfo to hold the values that the game holds at that point in time. When initially loading they will hold the default values.

int[] saveInfo = { Game.hp, Game.level, Game.mana, Game.expTotal,
                    Game.goldTotal, Game.arrow, Game.shuriken, Game.bomb,
                    Game.hpPotion, Game.mpPotion, Game.potion, Game.items };

The variables here:Game.hp=100, Save.saveInfo[0]=100

Then you set all of the game variables to saveInfo at the beginning of Save.savePlayer()

                    Game.hp = saveInfo[0];
                    Game.level = saveInfo[1];
                    Game.mana = saveInfo[2];
                    Game.expTotal = saveInfo[3];
                    Game.goldTotal = saveInfo[4];
                    Game.arrow = saveInfo[5];
                    Game.shuriken = saveInfo[6];
                    Game.bomb = saveInfo[7];
                    Game.hpPotion = saveInfo[8];
                    Game.mpPotion = saveInfo[9];
                    Game.potion = saveInfo[10];
                    Game.items = saveInfo[11];

The variables here:Game.hp=100, Save.saveInfo[0]=100 They don't change because you just set them back to their default values.

Then you load the saved state but you don't do anything with the data. You should be setting the variables after loading here so they're set to the new saveInfo values instead of the old.

for (int i = 0; i < saveInfo.length; i++) {
    saveInfo[i] = Integer.parseInt(inputReader.readLine());
}

Upvotes: 2

Related Questions