CODEWITHSUNDEEP
cmpi
Mike
Mike

Reputation: 53

MPI_Scatter and MPI_Reduce

I'm trying to find the max of randomly generated numbers. Any thoughts on this...

I am using MPI_Scatter to split the randomly generated numbers into equal processes. I am using MPI_Reduce to get the MAX from each process. 

#include <stdio.h>
#include <time.h>
#include <stdlib.h>
#include <mpi.h>

#define atmost 1000


int find(int* partial_max, int from, int to){
    int i, max;
    printf("%d----%d\n", from, to);

    max = partial_max[from];

    for (i = from + 1; i <= to; i++)
        if (partial_max[i] > max)
            max = partial_max[i];

    return max;
}

int main(){
    int i, j,n, comm_sz, biggest, b, my_rank, q,result;

    //1. Declare array of size 1000
    int a[atmost];

    //2. generate random integer of 0 to 999
    srand((unsigned)time(NULL));

    n = rand() % atmost;
    //n = 10;

    for (i = 0; i <= n; i++){
        a[i] = rand() % atmost;
        printf("My Numbers: %d\n", a[i]);

        //a[i] = i;
    }

    MPI_Init(NULL, NULL);
    MPI_Comm_size(MPI_COMM_WORLD, &comm_sz);
    MPI_Comm_rank(MPI_COMM_WORLD, &my_rank);

    //j is the size we will split each segment into
    j = (n / (comm_sz-1));
    int partial_max[j];
    int receive_vector[j];

    //Send random numbers equally to each process
    MPI_Scatter(a, j, MPI_INT, receive_vector,
        j, MPI_INT, 0, MPI_COMM_WORLD);

    int localmax;
    localmax = -1;
    for (i = 0; i <= comm_sz-1; i++)
        if (receive_vector[i] > localmax) 
            localmax = receive_vector[i];

    // Get Max from each process
    //MPI_Reduce(receive_vector, partial_max, j, MPI_INT, MPI_MAX, 0,       MPI_COMM_WORLD);
    MPI_Reduce(&localmax, &result, 1, MPI_INT, MPI_MAX, 0, MPI_COMM_WORLD);

    if (my_rank == 0)
    {
    /*
    biggest = -1;
    for (i = 0; i < comm_sz - 1; i++){
        if (i == comm_sz - 2)
            b = find(partial_max, i * j, n - 1);
        else
            b = find(partial_max, i * j, (i + 1) * j - 1);
        if (b > biggest)
            biggest = b;
    }*/
    printf("-------------------\n");
    printf("The biggest is: %d\n", result);
    printf("The n is: %d\n", n);
}

    MPI_Finalize();

    return 0;

}

Upvotes: 0

Views: 1469

Answers (1)

Tal Darom
Tal Darom

Reputation: 1409

You have few bugs there:

  1. You select (a different value of) n in each process. It is better to select it within rank 0 and bcast to the rest of the processes.
  2. When calculating j you divide by comm_sz-1 instead of comm_sz.
  3. You assume n is divisible by comm_sz and that each process receives the exact same amount of numbers to process.
  4. You loop with i going up to comm_sz-1 instead of going up to j

These are what I could find in a quick look..

Upvotes: 1

Related Questions